Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow array to be passed to to, cc, or bcc fields #137

Closed
cgsmith opened this issue Oct 9, 2024 · 2 comments
Closed

Allow array to be passed to to, cc, or bcc fields #137

cgsmith opened this issue Oct 9, 2024 · 2 comments

Comments

@cgsmith
Copy link
Contributor

cgsmith commented Oct 9, 2024

@ewood-ac - what do you think about a PR that allows either string or array for to, cc, and bcc fields? Would be curious to know your thoughts before making a draft PR an associated tests.

Doing this could also throw an exception when the arrays of to + cc + bcc exceed the 50 maximum addresses.
@ewood-ac
Copy link
Contributor

ewood-ac commented Oct 9, 2024

I think that would be a great addition. I will do my best to be responsive and review the code as quickly as I can and turn around a release.

@ewood-ac ewood-ac closed this as completed Oct 9, 2024
@cgsmith
Copy link
Contributor Author

cgsmith commented Oct 9, 2024

Excellent! I'll submit a PR in the next day or two.

@cgsmith cgsmith mentioned this issue Oct 9, 2024
Merged
ewood-ac pushed a commit that referenced this issue Oct 15, 2024
@cgsmith
Allow array syntax to sendEmail() or sendEmailWithTemplate() meth…
6892135 
…ods (#138)

Addresses issue raised in #137 

I also have a wiki update and will create an issue with a patch for this
since GitHub doesn't allow PRs on wikis :(

A couple notes:

- I wrote an extra Exception and validation check for this but removed
it since the library seems to leverage the Postmark API as the authority
for exceptions
- The `READ_SELENIUM_OPEN_TRACKING_TOKEN` was added to the example token
list due to an error I encountered when running PHPUnit tests locally

Thanks for the opportunity! This will be very useful to have in the
workflow on the library. It changes several API requests in my
application to one.

:1st_place_medal:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgsmith @ewood-ac