pull up cleanup functions

[rkuhn]

No description provided.

[rkuhn]

So the change is basically to switch from useState to useRef and manual re-render, right?

[rkuhn]

this is not enough: when stopping to follow a plant or robot, the machine-runner needs to be destroyed right here

[Kelerchian]

ah I see, the missing cancel call

[rkuhn]

why is this needed? shouldn’t it be enough to track cancellation callbacks and calling them?

[Kelerchian]

This is needed so that runPlant and runRobot know when the useEffect's lifetime ends.
The alternative to this will be a sync runPlant and runRobot, as you told me the last time, returning a cancellation callback which when called will flip a similar flag, although the alive flag will be inside each of runPlant and runRobot

[rkuhn]

This needs to update the plantId state as well.

[rkuhn]

should probably be conditional on the state actually being different

[rkuhn]

@Kelerchian I pushed a much smaller fix, see 1c6f11a#diff-26ad4b834941d9b19ebf9db8082bd202aaf72ea0ddea85f5a8a0cb3c729cc6f2R143-R154

[Kelerchian]

So the change is basically to switch from useState to useRef and manual re-render, right?

The main change is the switch from Mgmt[] to Map<Mgmt> to get a free duplication check, and the cancellations.
The change from useState to useRef is so that the syntax in add, del etc is not confusing because we're dealing with a Map.
Otherwise, we will be forced to do something like this, which makes the code unnecessarily complex:

setter((oldMap) => {
  const newMap = new Map(oldMap) // must always be done because React's state comparison uses equality and the same reference to Map will always be true and will skip a render trigger
  // operate on newMap here...
  return newMap
})