Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Julia & Natalie #23

Open
wants to merge 80 commits into
base: master
Choose a base branch
from

Conversation

NatalieTapias
Copy link

@NatalieTapias NatalieTapias commented Dec 20, 2019

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C12/video-store-consumer-api#15 (we also deployed to heroku! : front end: https://nt-jk-video-store-consumer.herokuapp.com/ api : http://nt-jk-video-store-consumer-api.herokuapp.com/movies )
For each person in your pair, describe something you learned from your partner during this project Natalie: Persistence is key when trying to map through a collection and you are getting lots of errors. Julia: I learned that you can do really cool things with conditional render/return.
What was one area of React you gained more clarity on during this assignment? Natalie: managing and updating state with an external API. Julia: how to pass around props!
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We used different components entirely: Movie for movies in the MovieCollection, then SearchResult that appear within the Search component. With more time we would refactor Search to nest Movie components rather than SearchResult. We do have some unique styling that applies only to SearchResult components, so the current configuration works out well for us!
Describe how you handled rentals with React We used an onClick function that initiates a post request to the Video-Store-Consumer-Api rentals endpoint. The button to perform this function appears only when both a Movie and a Customer have been selected.
Describe a DOM event your application handled ComponentDidMount() is in the App component, where we make our API get requests in order to populate the customers and rentals.
Did you use any functional stateless components? What for? Yes, we used functional components for SearchResult, CustomerList, MovieCollection, and Customer.
Did you use any container components? What for? Yes we used container components every time we wanted to show a collection of components: MovieCollection, CustomerList, and Search.
Do you have any recommendations on how we could improve this project for the next cohort? Natalie: no recommendations! Julia: No!

NatalieTapias and others added 30 commits December 16, 2019 14:08
NatalieTapias and others added 30 commits December 18, 2019 12:59
Testing - Snapshot testing for Front End
…r or not a search result is already in rental library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants