Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branches - Xinran & Eve #24

Open
wants to merge 79 commits into
base: master
Choose a base branch
from
Open

Conversation

tofuandeve
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C12/video-store-consumer-api#17
For each person in your pair, describe something you learned from your partner during this project Eve: I learned how to use Modal component in bootstrap from Xinran, it makes our CustomerDetails cards look very nice, and also rendering more information from rails API
Xinran: I learned many ways to use git and message handlings/displayings from Eve.
What was one area of React you gained more clarity on during this assignment? Interation between React App and API
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We passed in different props to MovieLibrary components, and the same for Movie components
Describe how you handled rentals with React We made post request to create new rental and also made post request when checking in a rental
Describe a DOM event your application handled We used onClick when user clicks on a button
Did you use any functional stateless components? What for? MovieDetail for displaying a selected movie's details and Movie to display movie card.
Did you use any container components? What for? One of the container components we used is MovieLibrary to keep information of all the movies.
Do you have any recommendations on how we could improve this project for the next cohort? Maybe clarify that React App should not interact directly with external API but with the video-store-consumer-api instead

gracexinran and others added 30 commits December 16, 2019 14:33
Added MovieLibrary and Movie components
CustomerList and Customer components
Refactored and added react routes
added css to customers and movies
tofuandeve and others added 30 commits December 19, 2019 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants