Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaves - Georgina and Sabrina #7

Open
wants to merge 68 commits into
base: master
Choose a base branch
from

Conversation

Galaxylaughing
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API API PR
For each person in your pair, describe something you learned from your partner during this project Sabrina: More about how to use snapshot tests; Georgina: How some code is too complicated to put into the arguments of a ternary operation.
What was one area of React you gained more clarity on during this assignment? Working with axios, keeping the state up to date with the axios requests, and working with conditionals to show the right thing.
Describe how you solved the problem of having lists of movies that look mostly the same but have different content We had a MovieList component that rendered a collection of Movie components, where the list fed the data from each movie into a different Movie component.
Describe how you handled rentals with React We make an axios POST request to checkout a movie to a customer, feeding the selected customer and selected movie data held in state into the request body. If the request succeeds, we look up the customer object in state and add one to its movies_checked_out_count.
Describe a DOM event your application handled We have buttons that react to onClick events, and we have text fields that keep track of what has been inputted into the field.
Did you use any functional stateless components? What for? Home, FlashMessage, CustomerRow, CustomerList, and Checkout are all stateless components. They are receiving their information from the App and its state data.
Did you use any container components? What for? App.js is a container component which contains all of the other components.
Do you have any recommendations on how we could improve this project for the next cohort? Maybe clarify some of the instructions, like how the search function is supposed to work. Maybe link to the API from the main project README and vice versa, so future cohorts don't get confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants