Remove Jetifier #350
Merged
Remove Jetifier #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 28, 2020 12:12
alorma
approved these changes
May 28, 2020
|
Uhmmm, tests are all green |
|
Cool! In this case, the less, the better. Crossed fingers that it doesn't give any issue when releasing it 🤞 If something bad happens, @BraisGabin we'll call you at midnight! 🌙 |
rocboronat
approved these changes
May 28, 2020
|
Thank you @BraisGabin! |
This was referenced May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library doesn't depend on any android support library (except glide, that it's just used in the sample app and I updated it). So we can remove jetifier safely and get faster builds 🎉.
I needed to update
mockito-androidbecause when I removed jetifier mockito start complaining about "final interfaces". The ways ofthe lordmockito are inscrutable.BTW: there are two tests failing at
masterright now and they fail in this PR too:checkColorList_whenDisabledandcheckColorList_whenChecked.