Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Day night rule #359

Merged
merged 5 commits into from
Aug 18, 2020
Merged

Day night rule #359

merged 5 commits into from
Aug 18, 2020

Conversation

alorma
Copy link
Member

@alorma alorma commented Aug 4, 2020

Add DayNightRule so we can run tests on any of the DayNight modes, by default it launches on DAY and NIGHT modes

This PR fixes #358

untitled

@rocboronat
Copy link
Member

Hey @alorma! Thanks a lot for this PR! You solved it faster than I wrote the issue, hehe!

Do you want me to introduce the rule in the README?

@alorma
Copy link
Member Author

alorma commented Aug 18, 2020

Sure @rocboronat!

@alorma alorma merged commit 0fae4c4 into master Aug 18, 2020
@alorma alorma deleted the day_night branch August 18, 2020 18:44
@Sloy
Copy link
Member

Sloy commented Aug 18, 2020

Wait, weren't you waiting for the readme?
tenor-64053998

@alorma
Copy link
Member Author

alorma commented Aug 19, 2020

No, @rocboronat will do in another PR (as he said)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass the tests in both Day and Night mode
3 participants