Add assertNoError method side of assertError methods #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alorma
force-pushed
the
no_Error
branch
2 times, most recently
from
59c75d7 to
30dd9e2
Compare
Sloy
reviewed
Mar 9, 2021
|
Heeey! Just wondering if Maybe today I would name it If you agree it, name your new method Thanks for the PR, Bernat! :-) |
rocboronat
previously approved these changes
Mar 9, 2021
|
@rocboronat renamed methods! |
|
Yey! Everything is perfect now but... there's always a but... if we merge this PR, we will break the API we offer right now. We should mark the old |
rocboronat
reviewed
Mar 10, 2021
| import com.schibsted.spain.barista.internal.assertAny | ||
| import org.hamcrest.Description | ||
| import org.hamcrest.Matcher | ||
| import org.hamcrest.TypeSafeMatcher | ||
|
|
||
| object BaristaErrorAssertions { | ||
|
|
||
| @Deprecated( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When playing with errors... we have a method to check for
assertError, error is displayed...But, we didn't had a method to check for error is not shown...