Update Espresso version #432
Conversation
-Update Espresso versions -Add to the sample app Multidex configuration since there was a Dex error after updating the Espresso versions
sample/build.gradle.kts
Outdated
| @@ -12,6 +12,7 @@ android { | |||
| defaultConfig { | |||
| minSdk = 19 | |||
| targetSdk = 30 | |||
| multiDexEnabled = true | |||
There was a problem hiding this comment.
Why was multidex enabled? Is the sampel app too big after the dependency changes?
If that's the case, it's probably easier to just bump the minSdk version to 21 and forget about multidex.
There was a problem hiding this comment.
I did not know that using minSdk into 21 would fix that issue, if it does then I will bump the minSdk version and remove multidex!
There was a problem hiding this comment.
Yes please, that would be great. Min SDK 21 is good enough for the sample.
library/build.gradle.kts
Outdated
| @@ -24,10 +24,12 @@ android { | |||
| } | |||
|
|
|||
| dependencies { | |||
| api("androidx.test.espresso:espresso-core:3.1.1") | |||
| api("androidx.test.espresso:espresso-contrib:3.1.1") | |||
| api("androidx.test.ext:junit:1.0.0") | |||
There was a problem hiding this comment.
I'm curious, why was this dependency added?
There was a problem hiding this comment.
I added that depency because I also updated the AndroidJUnit runner in androidx.test.runner.AndroidJUnit4 is deprecated and the new one is into androidx.test.ext.junit.runners.AndroidJUnit4. which depends on androidx.test.ext:junit.
There was a problem hiding this comment.
I think we can avoid this dependency altogether if we remove all those @RunWith(AndroidJUnit4::class) annotations from the tests. They are not really needed.
Then, this dependency won't be needed, right? Do you want to do it? I can send a commit otherwise.
|
Hi! I have removed the multidex and update the min SDK to 21. I just left the Barista minSdk in 19, but maybe we could bump it into 21 too. Also I have removed the AndroidJunit4 runner from all the test. Finally I have fixed some assertions test, those test failed because after updating the Espresso version some assertions messages changed, so I have changed all those messages. |
… to minSdk=21 and remove Multidex from sample app
There was a problem hiding this comment.
Thanks a lot, @JJaviMS!
Just one last thing and we'll merge. Look at the VisibilityAssertionsTest file. I think it was accidentally re-formatted with the wrong indentation. Check out the Formatting section in the readme, we use a custom formatter for Barista.
If you don't mind fixing the indentation on that file, I think we'll be ready to merge :)
| "View (with tag value: is \"presentTagValue\") didn't match condition (not is displayed on the screen to the user)"; | ||
| assertThat(thrown).isInstanceOf(BaristaException.class).hasMessage(expectedMessage); | ||
| } | ||
| @Rule |
…s and fix a failing test on ChipTest
Hi,
According to #430 I have updated the Espressor dependencies version. Due to a Dex error, caused by a too big Dex file, I had to add Multidex to the sample app.
I have also started to update some other versions, like the AndroidJUnit4 test runner and the Kotlin version (#431).