Fixes click on RecyclerView when ItemView is wrapped #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test proves that click() and clickUsingPerformClick() have different behaviors when clicking the parent (wrapper) of a view.
Tests are passing even though the feature is broken. \o/
The click listener should be on the row (itemView), not in the label (textView). Otherwise clicking the row won't open the next activity.
Otherwise use espresso's click action (which simulates a tap)
rocboronat
reviewed
May 3, 2017
| @@ -21,32 +21,32 @@ | |||
| @Test | |||
| public void checkClickRecyclerViewItem_byPosition_atTwo() { | |||
| clickRecyclerViewItem(R.id.recycler, 2); | |||
| assertDisplayed("Avocado"); | |||
| assertDisplayed("Avocado has been clicked"); | |||
rocboronat
reviewed
May 3, 2017
| view.performClick(); | ||
| } else { | ||
| click().perform(uiController, view); | ||
| } |
There was a problem hiding this comment.
As this is a bit of magic, we should explain why are we doing this trick. I don't have any suggestions but I feel that project newcomers will cry when they see this thing.
There was a problem hiding this comment.
Maybe if we extract the line click().perform(uiController, view); to a method called propagateClickToChildren()?
rocboronat
reviewed
May 3, 2017
| new ActivityTestRule<>(WrappedViewActivity.class); | ||
|
|
||
| @Test | ||
| public void click_on_button() throws Exception { |
There was a problem hiding this comment.
There are tons of tests written with the camel case style. If you prefer to start using other style, please, change all Barista's tests.
|
It's merge time! Feel free to bump a new version 🎉 |
rocboronat
approved these changes
May 3, 2017
This was referenced May 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue in #47.
On PR #40 we introduced a change to avoid clicking wrong things in a RecyclerView row, and allow clicking child views inside a row.
Unfortunately, that last change also broke the click when the ClickListener is set in a child view and not directly in the ItemView, as described in #47.
In this PR we:
WrappedViewClickTest).performClick()when the view is clickable, or else use Espresso'sclick()action to allow propagating the click as usual.