Disallowed domains must be case insensitive

[HorayNarea]

Prerequisites

• I am running the latest version
• I checked the documentation and found no answer
• I checked to make sure that this issue has not already been filed

Issue Details

In the DNS settings one can configure "disallowed domains", queries to these domains actually are not answered but they still appear in the logs and the clients who send these queries appear in the statistics on the dashboard.

Expected Behavior

AGH handles "disallowed domains" exactly like "disallowed clients", so these queries should not appear in logs and statistics.

Actual Behavior

AGH only ignores queries for "disallowed domains" but still includes them in logs and dashboard statistics.

Screenshots

Screenshot:

Additional Information

I consider this a bug, if you don't agree please understand this as a feature request for a config flag to have both "disallowed"-things be treated alike.

[ameshkov]

Definitely a bug.

[ameshkov]

Appears to be a rather simple bug:

• dig -t a version.bind. @127.0.0.1 -- gets blocked
• dig -t a VERSION.BIND. @127.0.0.1 -- not blocked

The bug is originally in the https://github.com/AdguardTeam/urlfilter library.

[DandelionSprout]

Additional context:

Currently (and for the past 2 years), any queries for domains in Disallowed domains, are simply given a REFUSED result, and the queries are still listed in both AGH's statistics and logs.

As a result, it is far from unusual for AGH installations where port 53 is open, to see their frontpage statistics consist primarily of several dozen webhost port scanners, usually ones from PR-China, Romania, Netherlands, and Russia.

What me and Horay wish for, is for Disallowed domains to be treated the same way Disallowed clients do, so that the queries do not show up in the statistics or logs.

[ameshkov]

@DandelionSprout that's exactly how disallowed domains work - the queries are simply dropped. You can see REFUSED result only when for some reason domain has passed the check.

[EugeneOne1]

Hello to you, @HorayNarea and @DandelionSprout. We've brought the little fix for this issue. It's available in the latest edge builds as of snapshot f41d5b9. Could you please check, if it works fine now?

[HorayNarea]

On quick glance it looks like it works 👍
I'll run the edge build for a few hours now to have a real world test.

[DandelionSprout]

I'm on the beta channel (as opposed to Nightly) and can't test tonight, at least.

[EugeneOne1]

We'll close the issue for now. Please, feel free to reopen it in case you face it again.