-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic / Termination filterMsg #3551
Comments
Also, I just realized that dnsproxy has its own repo: https://github.com/AdguardTeam/dnsproxy |
It seems to be happening a few times per day, but each time it does successfully restart and continue (same stack trace). |
Just in case, could you please record the verbose-level log as well?
|
Merge in DNS/dnsproxy from 3551-dont-panic to master Updates AdguardTeam/AdGuardHome#3551. Squashed commit of the following: commit 570d149 Author: Eugene Burkov <[email protected]> Date: Wed Sep 8 17:20:46 2021 +0300 proxy: fix index panic
Merge in DNS/adguard-home from 3551-dont-panic to master Updates #3551. Squashed commit of the following: commit 45560e1 Author: Eugene Burkov <[email protected]> Date: Wed Sep 8 20:00:27 2021 +0300 all: upd dnsproxy
@lex-obrien, the latest build in the edge channel should fix the issue. Could you please check, if it still panics? |
Thank you, trying it now! |
Merge in DNS/adguard-home from 3551-dont-panic to master Updates #3551. Squashed commit of the following: commit 45560e1 Author: Eugene Burkov <[email protected]> Date: Wed Sep 8 20:00:27 2021 +0300 all: upd dnsproxy
@lex-obrien, we'll close the issue for now. Please, feel to reopen it if the panic recurs. |
Do you know when v0.107.0-b.10 will be released? |
@haberdabers, in a couple of hours, if all goes to plan. |
Merge in DNS/adguard-home from 3551-dont-panic to master Updates AdguardTeam#3551. Squashed commit of the following: commit 45560e1 Author: Eugene Burkov <[email protected]> Date: Wed Sep 8 20:00:27 2021 +0300 all: upd dnsproxy
Issue Details
running
AdGuard Home, version v0.107.0-b.9
Running from openWrt, downloaded from github release
Arm v7
Receive a panic which caused the service to die and then restart.
I have only seen it once, but panics are definitely not good :)
panic: runtime error: index out of range [0] with length 0
goroutine 43834 [running]:
github.com/AdguardTeam/dnsproxy/proxy.filterMsg(0x28191d0, 0x28191d0, 0x1e70000, 0x0)
github.com/AdguardTeam/[email protected]/proxy/cache.go:427 +0x1ac
github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).Resolve(0x252c540, 0x2061b90, 0x0, 0x0)
github.com/AdguardTeam/[email protected]/proxy/proxy.go:502 +0xc0
github.com/AdguardTeam/AdGuardHome/internal/dnsforward.(*Server).processUpstream(0x21b7600, 0x24fc420, 0x0)
github.com/AdguardTeam/AdGuardHome/internal/dnsforward/dns.go:544 +0x68
github.com/AdguardTeam/AdGuardHome/internal/dnsforward.(*Server).handleDNSRequest(0x21b7600, 0x252c540, 0x2061b90, 0x0, 0x0)
github.com/AdguardTeam/AdGuardHome/internal/dnsforward/dns.go:102 +0x21c
github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).handleDNSRequest(0x252c540, 0x2061b90, 0x3, 0x2661c20)
github.com/AdguardTeam/[email protected]/proxy/server.go:127 +0x1e4
github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).udpHandlePacket(0x252c540, 0x2998540, 0xe0, 0xe0, 0x28fce80, 0x10, 0x10, 0x27bc2e8, 0x256c448)
github.com/AdguardTeam/[email protected]/proxy/server_udp.go:105 +0x194
github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).udpPacketLoop.func1(0x252c540, 0x2998540, 0xe0, 0xe0, 0x28fce80, 0x10, 0x10, 0x27bc2e8, 0x256c448, 0x1ac9440, ...)
github.com/AdguardTeam/[email protected]/proxy/server_udp.go:74 +0x5c
created by github.com/AdguardTeam/dnsproxy/proxy.(*Proxy).udpPacketLoop
github.com/AdguardTeam/[email protected]/proxy/server_udp.go:73 +0x334
The text was updated successfully, but these errors were encountered: