Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot set bind_host in AdGuardHome.yaml (docker version) #4231

Closed
pexcn opened this issue Jan 30, 2022 · 7 comments
Closed

Cannot set bind_host in AdGuardHome.yaml (docker version) #4231

pexcn opened this issue Jan 30, 2022 · 7 comments
Assignees
@EugeneOne1
Labels
bug docker Docker-related issues P3: Medium
Milestone
v0.107.33

Comments

@pexcn
Copy link

pexcn commented Jan 30, 2022 •
edited
Loading

Issue Details

Hi guys:
Now I am using v0.107.3 version, I want to change bind_host to 192.168.1.1, but after restarting adguardhome, the value in the configuration file will automatically change to 0.0.0.0.

Maybe it has something to do with this line of the Dockerfile https://github.com/AdguardTeam/AdGuardHome/blob/v0.107.3/scripts/make/Dockerfile#L59, can it be fixed in the future? 😄
@EugeneOne1 EugeneOne1 added bug docker Docker-related issues P3: Medium labels Jan 31, 2022
@EugeneOne1 EugeneOne1 added this to the v0.107.4 milestone Jan 31, 2022
@EugeneOne1 EugeneOne1 self-assigned this Jan 31, 2022
@agneevX agneevX mentioned this issue Jan 31, 2022
Closed
@ainar-g ainar-g modified the milestones: v0.107.4, v0.108.0 Feb 1, 2022
@ainar-g ainar-g mentioned this issue Feb 9, 2022
Open
@pexcn
Copy link
Author

pexcn commented Oct 18, 2022

Is there an update on this issue? 😀 @ainar-g

@jonathanjsimon
Copy link

jonathanjsimon commented Nov 28, 2022 •
edited
Loading

Necrobumping

With the -h 0.0.0.0 in the Dockerfile, AdGuard becomes unusable in my use case as I have two interfaces and port 80 is in use on one of them. Specifying the other interface's IP is the only way to use AdGuard and have individual client IPs listed in the interface.

@jonathanjsimon
Copy link

For anyone wanting to do this now, https://hub.docker.com/r/jsimon0/adguardhome

@MarioNoll
Copy link

Docker also allows overriding image defaults. So as a workaround I am using a custom command in my compose file omitting the host option:

command: [  "--no-check-update",  "-c",  "/opt/adguardhome/conf/AdGuardHome.yaml", "-w",  "/opt/adguardhome/work" ]

@ammnt ammnt mentioned this issue Apr 18, 2023
Closed
3 tasks
adguard pushed a commit that referenced this issue Jun 22, 2023
@Mizzick
all: docker
b4adb0b 
Updates #4231.
adguard pushed a commit that referenced this issue Jun 22, 2023
@Mizzick
all: docs
eef1b5c 
Updates #4231.
adguard pushed a commit that referenced this issue Jun 23, 2023
@Mizzick
Pull request: web-addr-cmdline
e54fc9b 
Merge in DNS/adguard-home from web-addr-cmdline to master

Squashed commit of the following:

commit 27652db
Author: Dimitry Kolyshev <[email protected]>
Date:   Thu Jun 22 17:51:43 2023 +0400

    home: web-addr opt

commit b234d10
Merge: eef1b5c 66345e8
Author: Dimitry Kolyshev <[email protected]>
Date:   Thu Jun 22 17:10:57 2023 +0400

    Merge remote-tracking branch 'origin/master' into web-addr-cmdline

    # Conflicts:
    #	CHANGELOG.md

commit eef1b5c
Author: Dimitry Kolyshev <[email protected]>
Date:   Thu Jun 22 17:04:12 2023 +0400

    all: docs

    Updates #4231.

commit b4adb0b
Author: Dimitry Kolyshev <[email protected]>
Date:   Thu Jun 22 16:58:12 2023 +0400

    all: docker

    Updates #4231.

commit a4012fd
Author: Dimitry Kolyshev <[email protected]>
Date:   Thu Jun 22 11:24:02 2023 +0400

    all: docker

commit bd5cc33
Merge: 36841dd 123ca87
Author: Dimitry Kolyshev <[email protected]>
Date:   Thu Jun 22 11:22:51 2023 +0400

    Merge remote-tracking branch 'origin/master' into web-addr-cmdline

commit 36841dd
Author: Dimitry Kolyshev <[email protected]>
Date:   Wed Jun 21 11:53:40 2023 +0400

    all: docker

commit 5c4756a
Author: Dimitry Kolyshev <[email protected]>
Date:   Wed Jun 21 11:50:41 2023 +0400

    all: imp docs

commit 7b6fba8
Merge: 54c1190 ca31352
Author: Dimitry Kolyshev <[email protected]>
Date:   Wed Jun 21 11:47:36 2023 +0400

    Merge remote-tracking branch 'origin/master' into web-addr-cmdline

commit 54c1190
Author: Dimitry Kolyshev <[email protected]>
Date:   Tue Jun 20 15:57:54 2023 +0400

    home: imp code

commit c87e0a6
Author: Dimitry Kolyshev <[email protected]>
Date:   Tue Jun 20 15:56:45 2023 +0400

    all: imp docs

commit de240d0
Author: Dimitry Kolyshev <[email protected]>
Date:   Tue Jun 20 15:54:27 2023 +0400

    all: docker

commit 568d537
Author: Dimitry Kolyshev <[email protected]>
Date:   Tue Jun 20 13:38:53 2023 +0400

    all: docs

commit 407e230
Author: Dimitry Kolyshev <[email protected]>
Date:   Tue Jun 20 13:24:23 2023 +0400

    home: deprecate opts

commit 6e628fa
Author: Dimitry Kolyshev <[email protected]>
Date:   Tue Jun 20 13:18:10 2023 +0400

    home: web-addr opt
@Mizzick
Copy link
Contributor

Mizzick commented Jun 23, 2023

Please have a look, we have implemented the requested changes.
The new build version v0.108.0-a.579+e54fc9b1 has been just published to the edge channel.

@ainar-g ainar-g mentioned this issue Jun 29, 2023
Open
4 tasks
@ainar-g ainar-g modified the milestones: v0.108.0, v0.107.33 Jul 3, 2023
@ainar-g
Copy link
Contributor

ainar-g commented Jul 3, 2023 •
edited
Loading

This should be fixed as of v0.107.33. Can any of you please check?

@MarioNoll
Copy link

@ainar-g Works fine in v.0.107.33, thanks!

@ainar-g ainar-g closed this as completed Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug docker Docker-related issues P3: Medium
Projects
None yet
Milestone
v0.107.33
Development

Successfully merging a pull request may close this issue.

Remove CMD host flag from Dockerfile agneevX/AdGuardHome
6 participants
@jonathanjsimon @pexcn @ainar-g @MarioNoll @Mizzick @EugeneOne1