-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client ID does not work in DoT and DoQ #4782
Comments
Hello.
This is the mistake. AdGuard Home uses the data from that field to separate the ClientIDs from the rest of the ClientHello TLS message. We should probably mention that both in the UI as well as in the Wiki. |
Sorry, it's my bad. I misunderstood the meaning of the prompt. The Server Name field prompts that leaving it blank will accept incoming TLS connections for any domains, which I thought I needed to leave blank in order for the wildcard domain to work properly. Should I keep this issue open? |
Yes, we'll close it once the UI and the docs are updated. |
Updates #4782. Squashed commit of the following: commit d350b38 Author: Natalia Sokolova <[email protected]> Date: Tue Jul 26 18:39:38 2022 +0300 client: imp wording commit d078531 Author: Ainar Garipov <[email protected]> Date: Tue Jul 26 17:16:41 2022 +0300 client: imp tls server name label
Updates #4782. Squashed commit of the following: commit d350b38 Author: Natalia Sokolova <[email protected]> Date: Tue Jul 26 18:39:38 2022 +0300 client: imp wording commit d078531 Author: Ainar Garipov <[email protected]> Date: Tue Jul 26 17:16:41 2022 +0300 client: imp tls server name label
Updates AdguardTeam#4782. Squashed commit of the following: commit d350b38 Author: Natalia Sokolova <[email protected]> Date: Tue Jul 26 18:39:38 2022 +0300 client: imp wording commit d078531 Author: Ainar Garipov <[email protected]> Date: Tue Jul 26 17:16:41 2022 +0300 client: imp tls server name label
Updates AdguardTeam/AdGuardHome#4782. Squashed commit of the following: commit 338b1df52b85054c71180b230c7b3f7bc7dfc992 Author: Ainar Garipov <[email protected]> Date: Tue Jul 26 19:01:48 2022 +0300 Configuration: imp server_name docs
Prerequisites
Issue Details
v0.108.0-b.10
GitHub Release
Dedicated server
Dedicated server
AMD64
Debian 11
Expected Behavior
When requesting DNS via
tls://<client-id>.domain.tld
andquic://<client-id>.domain.tld
, AdGuard Home should be able to correctly identify the Client ID and display it in the statistics.Actual Behavior
The statistics do not show the Client ID, but only the IP address of the requesting party. Only DoH (
https://domain.tld/dns-query/<client-id>
) can be correctly counted as Client ID.AdGuard Home has a wildcard certificate containing SAN
*.domain.tld
and has properly added wildcard DNS resolution.The Server Name in the encryption settings has been left blank.
Tests performed using dnslookup as a client.
Screenshots
Screenshot:
The text was updated successfully, but these errors were encountered: