Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll is not working when pressing on device logo #4926

Closed
3 tasks done
MkQtS opened this issue Sep 17, 2022 · 2 comments
Closed
3 tasks done

Scroll is not working when pressing on device logo #4926

MkQtS opened this issue Sep 17, 2022 · 2 comments
Assignees
@IldarKamalov
Labels
bug P3: Medium UI
Milestone
v0.107.14

Comments

@MkQtS
Copy link
Contributor

MkQtS commented Sep 17, 2022

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Linux, OpenWrt

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On a router, DHCP is handled by the router

AdGuard Home version

v0.107.13

Description

What did you do?

  1. Visit AdGuard Home Setup Guide page using a mobile browser
  2. Press on the device logo and try to scroll horizontally

Expected result

The device logo folows my finger

Actual result

It's not scrollable when pressing on the device logos

Screenshots (if applicable)

image

Only the green area is scrollable, pressing and scrolling on red area is not working.
@ainar-g ainar-g added this to the v0.107.14 milestone Sep 19, 2022
adguard pushed a commit that referenced this issue Sep 19, 2022
@IldarKamalov
Pull request: 4926 fix tabs scroll on mobile
ab6da05 
Updates #4926

Squashed commit of the following:

commit 23a352d
Merge: 44c6489 8e89cc1
Author: Ildar Kamalov <[email protected]>
Date:   Mon Sep 19 19:35:48 2022 +0300

    Merge branch 'master' into 4926-scroll

commit 44c6489
Author: Ildar Kamalov <[email protected]>
Date:   Mon Sep 19 19:34:54 2022 +0300

    fix

commit 3f8f8c7
Author: Ildar Kamalov <[email protected]>
Date:   Mon Sep 19 19:30:59 2022 +0300

    client: fix tabs scroll on mobile
annguyen0 pushed a commit to annguyen0/AdGuardHome that referenced this issue Sep 21, 2022
@IldarKamalov @annguyen0
Pull request: 4926 fix tabs scroll on mobile
0c66a78 
Updates AdguardTeam#4926

Squashed commit of the following:

commit 23a352d
Merge: 44c6489 8e89cc1
Author: Ildar Kamalov <[email protected]>
Date:   Mon Sep 19 19:35:48 2022 +0300

    Merge branch 'master' into 4926-scroll

commit 44c6489
Author: Ildar Kamalov <[email protected]>
Date:   Mon Sep 19 19:34:54 2022 +0300

    fix

commit 3f8f8c7
Author: Ildar Kamalov <[email protected]>
Date:   Mon Sep 19 19:30:59 2022 +0300

    client: fix tabs scroll on mobile
@ainar-g
Copy link
Contributor

ainar-g commented Sep 29, 2022

@MkQtS, hello. This should be fixed on the Edge channel. Could you please check if the UI behaves correctly now?

@MkQtS
Copy link
Contributor Author

MkQtS commented Sep 29, 2022

It works well now. Thanks for your work.

@MkQtS MkQtS closed this as completed Sep 29, 2022
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@IldarKamalov @heyxkhoa
Pull request: 4926 fix tabs scroll on mobile
12403c6 
Updates AdguardTeam#4926

Squashed commit of the following:

commit 23a352d
Merge: 44c6489 8e89cc1
Author: Ildar Kamalov <[email protected]>
Date:   Mon Sep 19 19:35:48 2022 +0300

    Merge branch 'master' into 4926-scroll

commit 44c6489
Author: Ildar Kamalov <[email protected]>
Date:   Mon Sep 19 19:34:54 2022 +0300

    fix

commit 3f8f8c7
Author: Ildar Kamalov <[email protected]>
Date:   Mon Sep 19 19:30:59 2022 +0300

    client: fix tabs scroll on mobile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IldarKamalov IldarKamalov

Labels
bug P3: Medium UI
Projects
None yet
Milestone
v0.107.14
Development

No branches or pull requests
3 participants
@IldarKamalov @ainar-g @MkQtS