Sourcery refactored main branch #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| token = os.getenv("GH_TOKEN") | ||
| if token: | ||
| if token := os.getenv("GH_TOKEN"): |
There was a problem hiding this comment.
Function auth_to_github refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-86
to
+85
| time_to_first_response = None | ||
| return None |
There was a problem hiding this comment.
Function measure_time_to_first_response refactored with the following changes:
- Lift return into if (
lift-return-into-if)
Comment on lines
-120
to
+117
| time_to_close = closed_at - created_at | ||
|
|
||
| return time_to_close | ||
| return closed_at - created_at |
There was a problem hiding this comment.
Function measure_time_to_close refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-238
to
+234
| [issue.time_to_close for issue in issues_with_time_to_close], timedelta() | ||
| (issue.time_to_close for issue in issues_with_time_to_close), | ||
| timedelta(), |
There was a problem hiding this comment.
Function get_average_time_to_close refactored with the following changes:
- Replace unneeded comprehension with generator (
comprehension-to-generator)
Comment on lines
-302
to
319
| if issue.state == "open": # type: ignore | ||
| num_issues_open += 1 | ||
| if issue.state == "closed": # type: ignore | ||
| if issue.state == "closed": | ||
| num_issues_closed += 1 |
There was a problem hiding this comment.
Function main refactored with the following changes:
- Simplify conditional into switch-like form (
switch)
Comment on lines
-331
to
-354
| repo_url = os.getenv("REPOSITORY_URL") | ||
| if not repo_url: | ||
| if repo_url := os.getenv("REPOSITORY_URL"): | ||
| return search_query, repo_url | ||
| else: | ||
| raise ValueError("REPOSITORY_URL environment variable not set") | ||
| return search_query, repo_url |
There was a problem hiding this comment.
Function get_env_vars refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Lift code into else after jump in control flow (
reintroduce-else) - Swap if/else branches (
swap-if-else-branches)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!