Skip to content

Commit

Permalink
Revert "fix: Xcode 12 compatibility (#209)"
Browse files Browse the repository at this point in the history 
This reverts commit 2502ffd.
  • Loading branch information
@Agontuk
Agontuk committed Nov 28, 2020
1 parent f8db5f0 commit b648af6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion react-native-geolocation-service.podspec
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ Pod::Spec.new do |s|

s.swift_version = "5.0"

s.dependency "React-Core"
s.dependency "React"
end

5 comments on commit b648af6

@mjmasn
Copy link

@mjmasn mjmasn commented on b648af6 Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Agontuk what was the reason for reverting this? My understanding is that it's needed to allow building on newer versions of React Native.

@Agontuk
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My build was failing after this change, so reverted it. Can you tell me from which RN version is the new change needed ?

@mjmasn
Copy link

@mjmasn mjmasn commented on b648af6 Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question - I think it's the combination of Xcode 12+ and RN 0.64, but we jumped from 0.63 to 0.66 recently so not 100% sure. Definitely after 0.63.x

@Agontuk
Copy link
Owner Author

@Agontuk Agontuk commented on b648af6 Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still build RN 0.65 without the change, will check 0.66

@jwoyame
Copy link

@jwoyame jwoyame commented on b648af6 Apr 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A project that has use_frameworks! for using this and other pods as a framework will not build unless s.dependency "React-Core" is patched into this file. At least, that's true on react-native v0.66.3.

Explanation: facebook/react-native#29633 (comment)

Please sign in to comment.