Overhaul swingset configuration #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUDCo
added
enhancement
|
It looks like some more changes landed on trunk after you branched off (but not mine, so I think they won't conflict). I'm going to experiment with github's "Update branch" button and see what it does. I think we'll want to rebase this whole thing before landing, to avoid the little rats nest of branches that this button will probably create. |
|
Yep, that button created a merge commit between the branch you pushed and current trunk, which is more messy than we'd want to land. But a |
FUDCo
force-pushed
the
refactor-swingset-config
branch
2 times, most recently
from
4cd6ad7 to
06151c6
Compare
warner
requested changes
Aug 6, 2020
FUDCo
force-pushed
the
refactor-swingset-config
branch
from
06151c6 to
6a4dee8
Compare
This was referenced Jan 17, 2022
Chris-Hibbert
added a commit
that referenced
this pull request
Dec 1, 2022
Modulo one issue that seems related to loopback (#1381), all tests pass, but there's a little more work to do. A few pieces of Zoe don't use Far classes. This should be a simple update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes implement the new swingset configuration model per #1331. A writeup of the deltas is in the file
APIChange.md(which should probably be rehomed or renamed or incorporated into some other file, but I wanted to get these changes documented without delaying for the time it would take me to get clear on the change notes publication flow).