fix(swingset): gc-actions: new algorithm, update test #3296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warner
force-pushed
the
3109-new-gc-actions
branch
from
64de132 to
a3a3f67
Compare
Implement the new algorithm to decide when a GC Action should be negated or bypassed.
warner
force-pushed
the
3109-new-gc-actions
branch
from
a3a3f67 to
6c85e21
Compare
FUDCo
reviewed
Jun 11, 2021
| const owner = kernelKeeper.ownerOfKernelObject(kref); | ||
| if (owner) { | ||
| return kernelKeeper.getObjectRefCount(kref); | ||
| function filterAction(vatKeeper, action, type, kref) { |
There was a problem hiding this comment.
This probably could use a comment explaining why the actions are being filtered, since the verb "filter" is pretty generic, i.e., what the respective meanings of the pre-filtration and post-filtration collections are supposed to be. I think what's happening is it's throwing away the actions that it's not actually going to perform this time through, but I'm not 100% sure my understanding is correct.
This was referenced Sep 15, 2021
Open
Open
Open
Open
Open
This was referenced Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the new algorithm to decide when a GC Action should be negated or
bypassed. This is intended to match the new contents of docs/garbage-collection.md .
refs #3106