feat(store): M.splitArray and M.splitRecord #6597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-split-reform-only
branch
2 times, most recently
from
9f60267 to
5fedea2
Compare
erights
force-pushed
the
markm-split-reform-only
branch
from
cd1cca9 to
6b8b56c
Compare
erights
force-pushed
the
markm-split-reform-only
branch
2 times, most recently
from
1371826 to
6405c35
Compare
turadg
requested changes
Nov 28, 2022
There was a problem hiding this comment.
just to provide the new feature. Because it is compat, this PR does not itself refactor the usage to use the feature.
This PR does change about a dozen test files outside store package so it looks like there are some changes here to adopt the feature. Maybe in defendSyncArgs using the new M.splitArray. I would have expected that change to be saved for #6431 .
That's not a blocker but I am requesting the documentation updates on MatchHelper
erights
force-pushed
the
markm-split-reform-only
branch
from
6405c35 to
47b5c90
Compare
turadg
approved these changes
Nov 29, 2022
erights
force-pushed
the
markm-split-reform-only
branch
from
47b5c90 to
5c2885d
Compare
erights
force-pushed
the
markm-split-reform-only
branch
from
5c2885d to
6344cff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested at #6431 (review) , this PR is extracted from #6431 just to provide the new feature. Because it is compat, this PR does not itself refactor the usage to use the feature.
So that we only bother to change most of these error messages once, this PR also borrows some code from #6432 for generating somewhat better errors.