-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear up presences vs. remotables #870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a start on review.
e13ab7d
to
0a12b1e
Compare
Please, all, take a look at tc39/proposal-eventual-send#11 |
@michaelfig please let me know when this has been updated to the latest eventual send API and terminology. |
0a12b1e
to
c0c5c0c
Compare
@erights I moved to the So, this is ready for review. |
fix: assign a singleton `globalThis.harden`
3c02bcc
to
aac1899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to see this, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the copying of errors are fixed.
This implements the first part of the #804 plan for explicitly creating remotables via the
@agoric/marshal
Remotable()
function.Remotable
andgetInterfaceOf
should be shared across marshal systems within the vat that imports them. I explicitly provide them to the liveSlots caller in order to expose to the vat code that uses it, rather than bundling a new copy of@agoric/marshal
and getting a different instance of the WeakMap that keeps the interface information.This is the smallest step forward that properly solves #792 without needing more far-reaching changes.
Here is some annotated REPL output: