ci(restore-node): preserve package.json timestamp
#9237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
changed the title
package.json timestamp
Deploying agoric-sdk with
|
| Latest commit: |
ab663fe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2a5b55ec.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mfig-9232-keep-package-json.agoric-sdk.pages.dev |
michaelfig
force-pushed
the
mfig-9232-keep-package-json-timestamp
branch
from
5715243 to
3ba7b93
Compare
michaelfig
added
the
automerge:no-update
|
@michaelfig , do you understand the CI failures? |
I have some ideas. It doesn't help that the Endo/Agoric canary CI on master appears to be breaking, too. I'll look at it when I can. |
michaelfig
force-pushed
the
mfig-9232-keep-package-json-timestamp
branch
from
3ba7b93 to
05db999
Compare
michaelfig
force-pushed
the
mfig-9232-keep-package-json-timestamp
branch
from
05db999 to
ab663fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9232
refs: #6432
Description
The
restore-nodeGithub action was updating the timestamp onpackage.jsonif there was an#endo-branch: XXXsetting on the PR. This causedagd-builder.shto rebuild the cached build artifacts unnecessarily, including using incorrect@endo/*package versions (the ones in the PR'spackage.jsons, not the ones from branchXXX).Now the
package.jsonis copied (preserving its timestamp), and moved back into place after installing any replaced packages.Security Considerations
n/a
Scaling Considerations
With this PR, shorter CI runs.
Documentation Considerations
n/a
Testing Considerations
n/a
Upgrade Considerations
n/a