Skip to content

Commit

Permalink
build: remove deprecated opentelemetry pacakegs
Browse files Browse the repository at this point in the history
BREAKING CHANGE : Jaeger configuration removed
  • Loading branch information
github-actions committed Nov 30, 2023
1 parent 1f64bbf commit 99bee99
Show file tree
Hide file tree
Showing 8 changed files with 4 additions and 112 deletions.
25 changes: 0 additions & 25 deletions doc/OPEN_TELEMETRY.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,31 +188,6 @@ To enable the [OTLP endpoint or Collector](https://opentelemetry.io/docs/collect

`OpenTelemetryProtocol` is deserialized into a [`OtlpExporterOptions`](https://github.com/open-telemetry/opentelemetry-dotnet/blob/4b3ee96ffc39bc24c3b8377455b2c099bd9da6b0/src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs) instance.

#### Jaeger

To enable the [Jaeger](https://www.jaegertracing.io/) exporter setup the `Jaeger` node:

```json
{
"OpenTelemetryOptions": {
"Trace": {
"Jaeger": {
"AgentHost": "exemple.com", //required
"AgentPort": 443 ,
"ExportProcessorType": "Batch",
"BatchExportProcessorOptions": {
"BatchExportProcessorOptions": 2048,
"ScheduledDelayMilliseconds": 5000,
"ExporterTimeoutMilliseconds": 30000,
"MaxExportBatchSize": 512
}
}
}
}
}
```

`Jaeger` is deserialized into a [`JaegerExporterOptions`](https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.Jaeger/JaegerExporterOptionsExtensions.cs) instance.

#### Zipkin

Expand Down
9 changes: 4 additions & 5 deletions src/Aguacongas.TheIdServer/Aguacongas.TheIdServer.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,12 @@
<PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="8.0.0" />
<PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.19.5" />
<PackageReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Design" Version="8.0.0" PrivateAssets="All" />
<PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.6.0" />
<PackageReference Include="OpenTelemetry.Exporter.Jaeger" Version="1.5.1" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs" Version="1.5.0-rc.1" />
<PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.7.0-rc.1" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.6.0" />
<PackageReference Include="OpenTelemetry.Exporter.Prometheus.AspNetCore" Version="1.7.0-rc.1" />
<PackageReference Include="OpenTelemetry.Exporter.Prometheus.HttpListener" Version="1.7.0-rc.1" />
<PackageReference Include="OpenTelemetry.Exporter.Zipkin" Version="1.6.0" />
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.6.0" />
<PackageReference Include="OpenTelemetry.Exporter.Zipkin" Version="1.7.0-rc.1" />
<PackageReference Include="OpenTelemetry.Extensions.Hosting" Version="1.7.0-rc.1" />
<PackageReference Include="OpenTelemetry.Instrumentation.AspNetCore" Version="1.0.0-rc9.14" />
<PackageReference Include="OpenTelemetry.Instrumentation.Http" Version="1.0.0-rc9.14" />
<PackageReference Include="OpenTelemetry.Instrumentation.SqlClient" Version="1.0.0-rc9.14" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,18 +107,6 @@ private static TracerProviderBuilder AddExporters(this TracerProviderBuilder bui
return builder;
}

if (!string.IsNullOrEmpty(options.Jaeger?.AgentHost))
{
builder = builder.AddJaegerExporter(o =>
{
var jaegerOptions = options.Jaeger;
o.AgentPort = jaegerOptions.AgentPort;
o.AgentHost = jaegerOptions.AgentHost;
o.BatchExportProcessorOptions = jaegerOptions.BatchExportProcessorOptions;
o.ExportProcessorType = jaegerOptions.ExportProcessorType;
});
}

if (options.OpenTelemetryProtocol?.Endpoint is not null)
{
builder = builder.AddOtlpExporter(o =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ public class TraceOptions
public bool ConsoleEnabled { get; set; }

public OtlpExporterOptions OpenTelemetryProtocol { get; set; }
public JaegerExporterOptions Jaeger { get; set; }
public ZipkinExporterOptions Zipkin { get; set; }
public HoneycombOptions Honeycomb { get; set; }

Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ public class TraceOptions
public bool ConsoleEnabled { get; set; }

public OtlpExporterOptions OpenTelemetryProtocol { get; set; }
public JaegerExporterOptions Jaeger { get; set; }
public ZipkinExporterOptions Zipkin { get; set; }
public HoneycombOptions Honeycomb { get; set; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,6 @@ public void AddTheIdServerTelemetry_should_add_exporters()
{
ApiKey = "test"
},
Jaeger = new JaegerExporterOptions
{
AgentHost = "google.com",
AgentPort = 443
},
Zipkin = new ZipkinExporterOptions
{
Endpoint = new Uri("https://google.com")
Expand Down

0 comments on commit 99bee99

Please sign in to comment.