Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version v22 #138

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Update node version v22 #138

merged 2 commits into from
Dec 24, 2024

Conversation

rmenner
Copy link
Contributor

@rmenner rmenner commented Dec 23, 2024

Alaska Airlines Pull Request

Resolves AlaskaAirlines/auro-templates#6

Before Submitting this pull request:

  • Link all tickets in this repository related to this PR in the Development section
    note: all pull requests require at least one linked ticket
  • If this PR is Ready For Review, all ticket's linked under Development must have their status changed to Ready For Review as well

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.

Summary by Sourcery

Update Node.js version to 20.x and 22.x.

Enhancements:

  • Update Node.js version to 20.x and 22.x in the project configuration.

CI:

  • Update CI workflow to test against Node.js versions 20.x and 22.x.

@rmenner rmenner self-assigned this Dec 23, 2024
Copy link

sourcery-ai bot commented Dec 23, 2024

Reviewer's Guide by Sourcery

This pull request updates the Node.js version to 20.x and 22.x for improved performance and compatibility. The changes include updating the required Node.js version in package.json files, updating the CI workflow to test against the new Node.js versions, and updating the branch protection rules to reflect the changes.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated Node.js version requirement
  • Changed the required Node.js version from 18.x and 20.x to 20.x and 22.x
package.json
packages/typescript/package.json
Updated CI workflow
  • Updated the test matrix in the CI workflow to use Node.js versions 20.x and 22.x, removing 18.x
.github/workflows/testPublish.yml
Updated branch protection rules
  • Updated the required status checks for branch protection to include tests for Node.js versions 20.x and 22.x, removing 18.x
.github/settings.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@rmenner rmenner marked this pull request as ready for review December 23, 2024 22:35
@rmenner rmenner requested a review from a team as a code owner December 23, 2024 22:35
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rmenner - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Node.js 22.x is currently not LTS and won't be until October 2024. Consider either waiting for LTS status before adding support, or document testing done to verify compatibility with this pre-LTS version.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@chrisfalaska chrisfalaska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update auro-library to 3.0.3?

@rmenner rmenner requested a review from chrisfalaska December 24, 2024 03:33
@rmenner rmenner dismissed chrisfalaska’s stale review December 24, 2024 16:47

I have updated what was request

@rmenner rmenner merged commit d086276 into beta Dec 24, 2024
4 checks passed
@rmenner rmenner deleted the rmenner/update-node-version-v22 branch December 24, 2024 16:48
@jason-capsule42
Copy link
Member

🎉 This PR is included in version 1.6.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants