-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node version v22 #138
Conversation
Reviewer's Guide by SourceryThis pull request updates the Node.js version to 20.x and 22.x for improved performance and compatibility. The changes include updating the required Node.js version in No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rmenner - I've reviewed your changes - here's some feedback:
Overall Comments:
- Node.js 22.x is currently not LTS and won't be until October 2024. Consider either waiting for LTS status before adding support, or document testing done to verify compatibility with this pre-LTS version.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update auro-library
to 3.0.3
?
I have updated what was request
🎉 This PR is included in version 1.6.0-beta.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Resolves AlaskaAirlines/auro-templates#6
Before Submitting this pull request:
Development
sectionnote: all pull requests require at least one linked ticket
Ready For Review
, all ticket's linked underDevelopment
must have their status changed toReady For Review
as wellBy submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I have performed a self-review of my own update.
Summary by Sourcery
Update Node.js version to 20.x and 22.x.
Enhancements:
CI: