Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text and icons are misaligned on non-bordered inputs #333

Closed
jordanjones243 opened this issue Sep 13, 2024 · 0 comments · Fixed by #335 or #338
Closed

Text and icons are misaligned on non-bordered inputs #333

jordanjones243 opened this issue Sep 13, 2024 · 0 comments · Fixed by #335 or #338
Assignees
@jordanjones243
Labels
auro-input

Comments

@jordanjones243
Copy link
Contributor

Please verify the version of auro-input you have installed

3.1.1

Please describe the bug

  1. Go to https://auro.alaskaair.com/components/auro/input/api
  2. Scroll to "Disabled" example
  3. Look at non-bordered input
  4. See how text appears lower than the icon

Reproducing the error on the docsite

This issue is reproducible on the Auro docsite

Expected behavior

Text and icon are aligned in both bordered and non-bordered inputs

What browsers are you seeing the problem on?

Chrome

Additional context

How the component looks:

Screen Shot 2024-09-13 at 11 24 38 AM

How it is supposed to look:

Screen Shot 2024-09-13 at 11 24 46 AM
@jordanjones243 jordanjones243 added Type: Bug Bug or Bug fixes auro-input not-reviewed Issue has not been reviewed by Auro team members labels Sep 13, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Sep 16, 2024
jordanjones243 added a commit that referenced this issue Sep 16, 2024
@jordanjones243
fix: realign text and icons on non-bordered inputs #333
395da89
@jordanjones243 jordanjones243 linked a pull request Sep 25, 2024 that will close this issue
Fix theming bugs #335
Merged
6 tasks
@jordanjones243 jordanjones243 mentioned this issue Sep 25, 2024
Merged
6 tasks
jordanjones243 added a commit that referenced this issue Sep 30, 2024
@jordanjones243
fix: realign text and icons on non-bordered inputs #333
39b3aaa
jordanjones243 added a commit that referenced this issue Sep 30, 2024
@jordanjones243
fix: realign text and icons on non-bordered inputs #333
d1c1df4
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
@semantic-release-bot
chore(release): 4.0.0-beta.1 [skip ci]
a806267 
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
jordanjones243 added a commit that referenced this issue Sep 30, 2024
@jordanjones243
fix: realign text and icons on non-bordered inputs #333
d922ae6
jordanjones243 pushed a commit that referenced this issue Sep 30, 2024
@semantic-release-bot @jordanjones243
chore(release): 4.0.0-beta.1 [skip ci]
fcd8766 
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
jordanjones243 pushed a commit that referenced this issue Sep 30, 2024
@semantic-release-bot @jordanjones243
chore(release): 4.0.0-beta.1 [skip ci]
b1602af 
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
jordanjones243 pushed a commit that referenced this issue Sep 30, 2024
@semantic-release-bot @jordanjones243
chore(release): 4.0.0-beta.1 [skip ci]
0f38cb3 
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
@jordanjones243 @jason-capsule42
fix: realign text and icons on non-bordered inputs #333
82006bc
jason-capsule42 pushed a commit that referenced this issue Sep 30, 2024
@semantic-release-bot @jason-capsule42
chore(release): 4.0.0-beta.1 [skip ci]
842ea12 
# [4.0.0-beta.1](v3.1.0-beta.3...v4.0.0-beta.1) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([d91e0e1](d91e0e1))
* realign text and icons on non-bordered inputs [#333](#333) ([d1c1df4](d1c1df4))
* remove private default of attribute ([03e9747](03e9747))
* resolve color theming issues ([0fa4568](0fa4568))
* **theming:** resolve minor theming issues [#296](#296) ([03c3fae](03c3fae))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([df7dd3a](df7dd3a))

### Performance Improvements

* refactor custom component registration config ([3ec2599](3ec2599))
* update dependencies ([d65d9f3](d65d9f3))

### BREAKING CHANGES

* trigger major release for color theming support #296
blackfalcon pushed a commit that referenced this issue Sep 30, 2024
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
4a47fad 
# [4.0.0](v3.0.1...v4.0.0) (2024-09-30)

### Bug Fixes

* add file extensions for SSR support ([bc39bcc](bc39bcc))
* realign text and icons on non-bordered inputs [#333](#333) ([82006bc](82006bc))
* remove private default of attribute ([3195d96](3195d96))
* resolve color theming issues ([65553a0](65553a0))
* **theming:** resolve minor theming issues [#296](#296) ([7802302](7802302))

### Features

* **autocomplete:** add html5 autocomplete functionality [#334](#334) ([f280e8f](f280e8f))
* refactor color token structure with tier 3 tokens [#296](#296) ([5653863](5653863))

### Performance Improvements

* **button:** use new auro-button flat variant for clear and show password ([2a671d2](2a671d2))
* **deps:** update to latest beta dependencies ([42ecf61](42ecf61))
* **icon:** update to use beta of auro-icon with theme support ([7df7568](7df7568))
* refactor custom component registration config ([89a5f20](89a5f20))
* replace hardcoded styles with tokens ([e9700ee](e9700ee))
* update dependencies ([7645408](7645408))

### BREAKING CHANGES

* trigger major release for color theming support #296
@jason-capsule42 jason-capsule42 linked a pull request Sep 30, 2024 that will close this issue
Beta #338
Merged
6 tasks
@jason-capsule42 jason-capsule42 removed the Type: Bug Bug or Bug fixes label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jordanjones243 jordanjones243

Labels
auro-input
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix theming bugs AlaskaAirlines/auro-input
Beta AlaskaAirlines/auro-input
3 participants
@jason-capsule42 @jordanjones243 @Patrick-Daly-AA