Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #98

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

sun-mota
Copy link
Contributor

@sun-mota sun-mota commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and revise contributing guidelines.

Build:

  • Update Node to v22.

CI:

  • Update CI to test on Node 20 and 22.

Documentation:

  • Revise contributing guidelines, including updating issue and pull request templates, code of conduct, and stale bot configuration.

Summary by Sourcery

Update Node to v22 and revise contributing guidelines.

Enhancements:

  • Update contributing guidelines with innersourcing flow guide, issue submission process, pull request process, commit message format, and rebase instructions.
  • Clarify team permissions and access in settings and contributing guidelines.
  • Add information about semantic versioning and conventional commits.

Build:

  • Update Node to v22.

CI:

  • Update CI to test on Node 20 and 22.

Documentation:

  • Revise contributing guidelines, including updating issue and pull request templates, code of conduct, and stale bot configuration.

@sun-mota sun-mota requested a review from a team as a code owner December 20, 2024 23:03
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This pull request updates the project to use Node.js v22 and revises the contributing guidelines.

Sequence diagram for updated PR review process

sequenceDiagram
    actor Contributor
    participant Issue as GitHub Issue
    participant PR as Pull Request
    participant Team as Auro Team

    Contributor->>Issue: Create issue
    Note over Issue: Wait up to 48h for response
    Team->>Issue: Review and discuss
    Contributor->>PR: Create PR after consultation
    Note over PR: Must follow conventional commits
    Team->>PR: Review within SLA
    Note over PR: Requires passing tests on<br/>Node 20.x and 22.x
Loading

File-Level Changes

Change Details Files
Updated Node.js version
  • Updated the Node.js version to v22 in package.json.
  • Updated the CI workflow to test on Node.js v20 and v22.
  • Regenerated package-lock.json with updated dependencies for Node.js v22
package.json
package-lock.json
.github/workflows/testPublish.yml
Revised contributing guidelines
  • Added information for Alaska Airlines employees, contractors, and vendors to the contributing guidelines.
  • Updated issue and pull request templates.
  • Revised the code of conduct.
  • Updated the stale bot configuration.
  • Updated team permissions in settings.yml
.github/CONTRIBUTING.md
.github/settings.yml
.github/stale.yml
.github/CODE_OF_CONDUCT.md
.github/CODEOWNERS

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sun-mota - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

.github/stale.yml Show resolved Hide resolved
@jason-capsule42 jason-capsule42 merged commit 6005e32 into main Dec 23, 2024
4 checks passed
@jason-capsule42 jason-capsule42 deleted the migration/package-update/node-22 branch December 23, 2024 17:53
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
3 participants