Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AURO MIGRATION: Update node to v22 #64

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

jason-capsule42
Copy link
Member

@jason-capsule42 jason-capsule42 commented Dec 20, 2024

Resolves AlaskaAirlines/auro-templates#6

Summary by Sourcery

Update Node to v22 and add team access settings.

Build:

  • Update Node version to 22.x.

CI:

  • Update CI to test on Node version 22.x.

Documentation:

  • Update contributing guidelines with innersource flow guide and conventional commit details.

@jason-capsule42 jason-capsule42 requested a review from a team as a code owner December 20, 2024 20:48
@jason-capsule42 jason-capsule42 self-assigned this Dec 20, 2024
Copy link

sourcery-ai bot commented Dec 20, 2024

Reviewer's Guide by Sourcery

This PR updates the project to use Node.js v22 and introduces several improvements to the project's documentation and tooling.

State diagram: Updated PR workflow states

stateDiagram-v2
    [*] --> PullRequest
    PullRequest --> Testing: Run tests
    Testing --> Node20: Test on Node 20.x
    Testing --> Node22: Test on Node 22.x
    Node20 --> Release: Tests pass
    Node22 --> Release: Tests pass
    Testing --> Failed: Tests fail
    Failed --> PullRequest: Fix issues
    Release --> Deployed: On main/beta branch
    Release --> [*]: On feature branch
    Deployed --> [*]
Loading

File-Level Changes

Change Details Files
Updated Node version
  • Updated Node version to v22 in GitHub settings
  • Updated test and publish workflow to use Node v22
  • Updated package.json to use Node v22
  • Regenerated package-lock.json
.github/settings.yml
.github/workflows/testPublish.yml
package.json
package-lock.json
Added a new workflow to publish a demo
  • Created a new workflow file to publish the demo on pull requests to the main branch
.github/workflows/publishDemo.yml
Improved documentation
  • Clarified contribution guidelines
  • Updated pull request template
.github/CONTRIBUTING.md
.github/PULL_REQUEST_TEMPLATE.md
Updated labels in settings
  • Updated labels in settings
.github/settings.yml
Updated code of conduct
  • Updated code of conduct
.github/CODE_OF_CONDUCT.md
Updated stale bot configuration
  • Updated stale bot configuration
.github/stale.yml
Updated CodeQL workflow
  • Updated CodeQL workflow
.github/workflows/codeql.yml
Updated CODEOWNERS file
  • Updated CODEOWNERS file
.github/CODEOWNERS

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

github-actions bot commented Dec 20, 2024

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jason-capsule42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@rmenner rmenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve #63 before this can be merged

@chrisfalaska chrisfalaska force-pushed the migration/package-update/node-v22 branch from 1b46c91 to 61593ee Compare December 23, 2024 18:34
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


chrisfalaska seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chrisfalaska chrisfalaska requested a review from rmenner December 23, 2024 19:01
@chrisfalaska chrisfalaska merged commit 66e18d1 into main Dec 23, 2024
5 of 7 checks passed
@chrisfalaska chrisfalaska deleted the migration/package-update/node-v22 branch December 23, 2024 19:05
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update defined node versions for latest security requirements
5 participants