Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading from 2.8.5 causes strange UI issues #178

Closed
jessieiswise opened this issue Feb 27, 2024 · 5 comments · Fixed by #182
Closed

Upgrading from 2.8.5 causes strange UI issues #178

jessieiswise opened this issue Feb 27, 2024 · 5 comments · Fixed by #182
Assignees
Labels
auro-select Type: Bug Bug or Bug fixes

Comments

@jessieiswise
Copy link

Describe the bug

After upgrading our Auro-select package from 2.8.5 to 2.9.6 I noticed unexpected Ui behavior where upon selection, the Auro-select is inserting some sort of text into the dropdown field

To Reproduce

1 use Auro select 2.9.x in a vue environment
2 observe that the select behavior is not as intended

** or if you don't have a vue env **

1 contact Jess on teams
2 Ask her to demo the issue
3 She will have a branch handy locally and will install the package at the specified version
4 Upon load of our web component, select a drop down option
5 Observe "Lit#" text in dropdown field

Expected behavior

No extraneous text in dropdown fields

Screenshots

Screenshot 2024-02-26 at 5 30 21 PM

Desktop (please complete the following information):

  • OS: Mac
  • Browser safari and chrome
  • Version latest

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

@jessieiswise jessieiswise added not-reviewed Issue has not been reviewed by Auro team members Type: Bug Bug or Bug fixes auro-select labels Feb 27, 2024
@blackfalcon
Copy link
Member

@jessieiswise in your test branch, can you install previous versions between >2.8.5 <=2.9.5? Possibly work backward, e.g. npm i @aurodesignsystem/[email protected] and see if we can zero in the version that introduced this bug?

What is clear is that, somehow, the HTML content that Lit uses to track nodes is being injected into the slot content. See the screenshot from the Auro doc site. While this UI issue is NOT happening in the doc site or locally running the element demo, Lit still produces the HTML comments you are seeing.

Image

The question is... why is this being injected into the slot? And why Vue? 🤔

@jessieiswise
Copy link
Author

I'll dig into this next week!

@jessieiswise
Copy link
Author

Looks like 2.9.0 is the offending version. possibly related to this commit? ddeedf8

@blackfalcon blackfalcon removed the not-reviewed Issue has not been reviewed by Auro team members label Mar 8, 2024
@jessieiswise
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-select Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants