Update CSS token per new design system theming capability #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also add fallback values to provided tokens Changes to be committed: modified: demo/index.html modified: package-lock.json modified: package.json modified: src/style.scss
|
The |
|
Also bumping |
fajar-apri-alaska
force-pushed
the
fajarapri/updateCSSToken
branch
from
0e6096e to
1cde3dd
Compare
jason-capsule42
requested changes
Nov 1, 2023
src/style.scss
Outdated
|
|
||
| /* stylelint-disable */ | ||
| &:hover { | ||
| background-color: var(--auro-color-ui-bkg-hover-on-light); | ||
| background-color: var(--ds-color-ui-bkg-hover-default); |
There was a problem hiding this comment.
My bad, thanks for noticing.
- auro-dropdown & auro-menu Changes to be committed: modified: package-lock.json modified: package.json
fajar-apri-alaska
force-pushed
the
fajarapri/updateCSSToken
branch
from
1cde3dd to
c8aa884
Compare
jason-capsule42
approved these changes
Nov 2, 2023
|
🎉 This PR is included in version 2.8.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Fixes: #163
Summary:
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team