Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add demo for matchWidth implementation in auro-select elements #173

Closed
wants to merge 2 commits into from

Conversation

irma-kurnia-alaska
Copy link

@irma-kurnia-alaska irma-kurnia-alaska commented Feb 5, 2024

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #101

Summary:

  • bump auro-dropdown version into 2.10.6
  • add new demo for match width

Type of change:

  • Other (update demo documentation)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@irma-kurnia-alaska irma-kurnia-alaska self-assigned this Feb 5, 2024
@irma-kurnia-alaska irma-kurnia-alaska requested a review from a team as a code owner February 5, 2024 03:35
@irma-kurnia-alaska irma-kurnia-alaska marked this pull request as draft February 5, 2024 03:35
@braven112 braven112 linked an issue Feb 7, 2024 that may be closed by this pull request
package.json Outdated
@@ -20,7 +20,7 @@
"node": "^18.x || ^20.x"
},
"dependencies": {
"@aurodesignsystem/auro-dropdown": "^2.10.0",
"@aurodesignsystem/auro-dropdown": "^2.10.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just leaving comment to remind that this will need to be updated again to latest version after AlaskaAirlines/auro-dropdown#217 is merged & released.

Copy link
Member

@blackfalcon blackfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@irma-kurnia-alaska in the PR comments you reference a version bump and in the commit message you list package.json as being modified.

I am not seeing these changes in the PR. Can you please resolve?

@irma-kurnia-alaska
Copy link
Author

irma-kurnia-alaska commented Mar 12, 2024

Hi @blackfalcon,

I carried out the revert process for the commit message because based on the feedback above that Auro does not need to manually bump version, I will correct the commit message. Meanwhile, for PR comments, I'm still waiting for the latest version update from the auro-dropdown release. Thank You.

Change to be committed:
newfiles: apiExamples/matchWidth.html
modified: demo/index.md
modified: docs/partials/index.md
Change to be committed :
modified: package-lock.json
modified: package.json
@irma-kurnia-alaska irma-kurnia-alaska marked this pull request as ready for review April 5, 2024 06:35
@blackfalcon
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo for flexible width containers
3 participants