-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add demo for matchWidth implementation in auro-select elements #173
Conversation
package.json
Outdated
@@ -20,7 +20,7 @@ | |||
"node": "^18.x || ^20.x" | |||
}, | |||
"dependencies": { | |||
"@aurodesignsystem/auro-dropdown": "^2.10.0", | |||
"@aurodesignsystem/auro-dropdown": "^2.10.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just leaving comment to remind that this will need to be updated again to latest version after AlaskaAirlines/auro-dropdown#217 is merged & released.
2080105
to
d612b73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@irma-kurnia-alaska in the PR comments you reference a version bump and in the commit message you list package.json as being modified.
I am not seeing these changes in the PR. Can you please resolve?
Hi @blackfalcon, I carried out the revert process for the commit message because based on the feedback above that Auro does not need to manually bump version, I will correct the commit message. Meanwhile, for PR comments, I'm still waiting for the latest version update from the auro-dropdown release. Thank You. |
Change to be committed: newfiles: apiExamples/matchWidth.html modified: demo/index.md modified: docs/partials/index.md
d612b73
to
e685449
Compare
Change to be committed : modified: package-lock.json modified: package.json
@jason-capsule42 jason-capsule42 closed this as completed in https://github.com/AlaskaAirlines/auro-dropdown/pull/217[on Mar 5](#101 (comment)) |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #101
Summary:
Type of change:
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team