Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auro-formvalidation logic #181

Merged
merged 6 commits into from
May 10, 2024
Merged

Conversation

jordanjones243
Copy link
Contributor

Alaska Airlines Pull Request

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Resolves: #179

Summary:

Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.

  • Implement auro-formvalidation and refactor attribute handling
  • Refactor attribute structure to fix dynamic creation of component error

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

@jordanjones243 jordanjones243 self-assigned this Apr 2, 2024
@jordanjones243 jordanjones243 linked an issue Apr 2, 2024 that may be closed by this pull request
@jordanjones243 jordanjones243 force-pushed the jjones/formvalidation/#179 branch from b51c552 to be0dd86 Compare April 2, 2024 06:10
@jordanjones243 jordanjones243 marked this pull request as ready for review April 5, 2024 20:54
@jordanjones243 jordanjones243 requested a review from a team as a code owner April 5, 2024 20:54
Copy link
Member

@blackfalcon blackfalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been sitting around for a while. Please make sure again that dependencies are up to date and rebase from main.

src/auro-select.js Outdated Show resolved Hide resolved
@jordanjones243 jordanjones243 force-pushed the jjones/formvalidation/#179 branch from ff09d1f to 2e52a70 Compare April 30, 2024 15:37
@jordanjones243 jordanjones243 force-pushed the jjones/formvalidation/#179 branch 2 times, most recently from 7448c5c to 985f377 Compare April 30, 2024 15:50
@jordanjones243 jordanjones243 force-pushed the jjones/formvalidation/#179 branch from 985f377 to 99c04b6 Compare May 3, 2024 18:13
Copy link
Member

@jason-capsule42 jason-capsule42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value property example on API page doesn't work in this branch but it does on the doc site.

The extract value example on API page doesn't work in this branch but it does on the doc site.

Somewhere along the line the nested select examples disappeared off the API page as well. Those need to get added back in.

Didn't we have a dynamic menu example here as well at some point?

src/auro-select.js Outdated Show resolved Hide resolved
@jordanjones243
Copy link
Contributor Author

The value property example on API page doesn't work in this branch but it does on the doc site.

The extract value example on API page doesn't work in this branch but it does on the doc site.

Somewhere along the line the nested select examples disappeared off the API page as well. Those need to get added back in.

Didn't we have a dynamic menu example here as well at some point?

All api examples are now working. The error that broke this was that the nested select example was not on the page. I removed this example from api.js because the functional example is broken and the overflow of the select is not being controlled properly. An issue for this was created here:

src/auro-select.js Outdated Show resolved Hide resolved
@jordanjones243 jordanjones243 force-pushed the jjones/formvalidation/#179 branch from 5155a3d to f57453e Compare May 10, 2024 17:32
@jason-capsule42 jason-capsule42 self-requested a review May 10, 2024 17:53
@jason-capsule42 jason-capsule42 merged commit 04d9967 into main May 10, 2024
6 checks passed
@jason-capsule42 jason-capsule42 deleted the jjones/formvalidation/#179 branch May 10, 2024 17:59
@blackfalcon
Copy link
Member

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement formvalidation repo
3 participants