-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement auro-formvalidation logic #181
Conversation
b51c552
to
be0dd86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been sitting around for a while. Please make sure again that dependencies are up to date and rebase from main.
ff09d1f
to
2e52a70
Compare
7448c5c
to
985f377
Compare
985f377
to
99c04b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value
property example on API page doesn't work in this branch but it does on the doc site.
The extract value
example on API page doesn't work in this branch but it does on the doc site.
Somewhere along the line the nested select examples disappeared off the API page as well. Those need to get added back in.
Didn't we have a dynamic menu example here as well at some point?
All api examples are now working. The error that broke this was that the nested select example was not on the page. I removed this example from |
5155a3d
to
f57453e
Compare
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #179
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
auro-formvalidation
and refactor attribute handlingType of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team