Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force dropdown bib min-width to not expand outside container #225 #226

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

rmenner
Copy link
Contributor

@rmenner rmenner commented Dec 17, 2024

Alaska Airlines Pull Request

Type of change:

Please delete options that are not relevant.

  • New capability
  • Revision of an existing capability
  • Infrastructure change (automation, etc.)
  • Other (please elaborate)

Checklist:

  • My update follows the CONTRIBUTING guidelines of this project
  • I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.

Thank you for your submission!

-- Auro Design System Team

Summary by Sourcery

Bug Fixes:

  • Fix dropdown menu to prevent it from expanding outside its container by setting a minimum width.

@rmenner rmenner self-assigned this Dec 17, 2024
@rmenner rmenner requested a review from a team as a code owner December 17, 2024 22:02
Copy link

sourcery-ai bot commented Dec 17, 2024

Reviewer's Guide by Sourcery

This PR modifies the dropdown component's styling to ensure the bibliography dropdown's minimum width matches its container width, preventing unwanted expansion. The change is implemented by adding a CSS rule with !important to override any conflicting styles.

Class diagram for updated dropdown styling

classDiagram
    class DropdownComponent {
        +width: 100%
        +min-width: 100% !important
        +max-width: -webkit-fill-available
        +overflow-y: scroll
    }
    note for DropdownComponent "Updated min-width to 100% with !important to prevent expansion outside container."
Loading

File-Level Changes

Change Details Files
Added CSS styling to control dropdown width
  • Added min-width: 100% !important to the popover part to match container width
  • Updated stylelint-disable comment to include declaration-no-important rule
src/style.scss

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

github-actions bot commented Dec 17, 2024

Surge demo deployment failed! 😭

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rmenner - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

src/style.scss Show resolved Hide resolved
@rmenner rmenner merged commit 6f0939c into main Dec 19, 2024
6 of 7 checks passed
@rmenner rmenner deleted the rmenner/dropdown/overflow-fix branch December 19, 2024 00:23
@blackfalcon
Copy link
Member

🎉 This PR is included in version 3.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blackfalcon blackfalcon added the released Completed work has been released label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Completed work has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown bib overflowing container on browser resize
3 participants