Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the ability to add classes to tags #1082

Merged
merged 5 commits into from
Nov 25, 2020
Merged

Conversation

holema
Copy link
Contributor

@holema holema commented Feb 16, 2020

… for h1-h5 an p. The classes which should be added the the paragraphes should be an array in the constructor.

src/trumbowyg.js Outdated Show resolved Hide resolved
src/trumbowyg.js Outdated Show resolved Hide resolved
src/trumbowyg.js Outdated Show resolved Hide resolved
@holema holema requested a review from Alex-D February 17, 2020 05:59
@holema
Copy link
Contributor Author

holema commented Feb 21, 2020

hello @Alex-D are you going to merge the request in the next version? if not, I have to use my version in my project, which is not my prefered way ;)

Copy link
Contributor Author

@holema holema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the fix I did

Copy link
Owner

@Alex-D Alex-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added code is too big and can be simplified, or I miss something?
Feel free to tell me if I'm wrong.

Copy link
Contributor Author

@holema holema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it

src/trumbowyg.js Outdated Show resolved Hide resolved
@holema holema requested a review from Alex-D May 25, 2020 20:36
@holema
Copy link
Contributor Author

holema commented Oct 7, 2020

Hello Alex, will you merge this branch in the future?

@Alex-D
Copy link
Owner

Alex-D commented Oct 7, 2020

I hope to merge it for the 2.22.0 soon, I just need to take some time to test it, and maybe rewrite it a bit :)

@Alex-D Alex-D added the to review PR which is ready to merge label Oct 7, 2020
@Alex-D
Copy link
Owner

Alex-D commented Oct 7, 2020

After re-read, I did not understand the value of a systematic addition of a class on an element. I let you add this on your own version, but I will not include it, sorry.

Thank you for your time :)

@Alex-D Alex-D closed this Oct 7, 2020
@holema
Copy link
Contributor Author

holema commented Oct 8, 2020

The possibility is, that when you use bootstrap for examle, you need to add "h1-responsive" class to the h1 tag, to show it properly on all devices.
Also it is possible to add some sytling classes to the tags, e.Ex. I use special classes on blockquotes and set a z-depth to show drop shadows.

@Alex-D Alex-D reopened this Oct 8, 2020
@Alex-D Alex-D changed the title add the possibility to add classes to the paragraph. this is possible… feat: add the ability to add classes to tags Nov 25, 2020
@Alex-D Alex-D merged commit b1adae0 into Alex-D:develop Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to review PR which is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants