-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the ability to add classes to tags #1082
Conversation
hello @Alex-D are you going to merge the request in the next version? if not, I have to use my version in my project, which is not my prefered way ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the fix I did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added code is too big and can be simplified, or I miss something?
Feel free to tell me if I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it
Hello Alex, will you merge this branch in the future? |
I hope to merge it for the 2.22.0 soon, I just need to take some time to test it, and maybe rewrite it a bit :) |
After re-read, I did not understand the value of a systematic addition of a class on an element. I let you add this on your own version, but I will not include it, sorry. Thank you for your time :) |
The possibility is, that when you use bootstrap for examle, you need to add "h1-responsive" class to the h1 tag, to show it properly on all devices. |
… for h1-h5 an p. The classes which should be added the the paragraphes should be an array in the constructor.