-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better documentation #39
Comments
Sounds good to me. It is a bit hard to figure out exactly what order these should all go in though - if the readme takes too long to get to an example will people be less likely to bother reading through and eventually using it? Cleaner API docs is definitely a good idea. |
@AlexGilleran Done. Could you review? |
@texttechne That's really great. I just had a few tweaks (capital letters, removing the notice about JSTransform at the top, changing some wording around, adding a link to react-if and reactjs/react-future#35). Tell me what you think :) |
The link to the react-future discussion is a really useful addition 👍 Regarding the link to react-if, I've thought about that, but didn't want to mention this or any of those libraries directly. Could be interpreted as blaming or finger pointing... but I leave this up to you 😉 And for completeness' sake there is the lazy evaluation workaround by wrapping the body in a function, although it is not explicitly mentioned in the docs. It's hinted at:
See the else branch; of course, this function wrapping would be required for the if branch as well. After having written it down, it is probably not worth to mention, after all it is still an ugly workaround which defeats the purpose of any such library. Thanks for the additions, corrections and stuff! |
Haha I never actually thought of the react-if thing that way, I thought of it more as a nod to what inspired this whole thing. Yeah I agree with leaving that out. Will release shortly :) 👍 |
We should put some effort into making the documentation better:
The text was updated successfully, but these errors were encountered: