[fix/MNT-23559-FixForRecordsManagementSearch] Fix for limited 500 items in RecordManagement Search #3165
Conversation
…ms in Records Management Search
mohit-singh4
requested review from
kavitshah-gl,
code4uuuu,
purusothaman-mm,
SathishK-T and
vedantmehra9
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -263,98 +273,98 @@ | |||
| * @param types | |||
| * @return | |||
| */ | |||
| /*package*/ String buildQueryString(String queryTerm, RecordsManagementSearchParameters searchParameters) | |||
| /* package */ String buildQueryString(String queryTerm, RecordsManagementSearchParameters searchParameters) | |||
Check warning
Code scanning / PMD
The method 'buildQueryString(String, RecordsManagementSearchParameters)' has a cognitive complexity of 32, current threshold is 27 Warning
| @@ -263,98 +273,98 @@ | |||
| * @param types | |||
| * @return | |||
| */ | |||
| /*package*/ String buildQueryString(String queryTerm, RecordsManagementSearchParameters searchParameters) | |||
| /* package */ String buildQueryString(String queryTerm, RecordsManagementSearchParameters searchParameters) | |||
Check warning
Code scanning / PMD
The method 'buildQueryString(String, RecordsManagementSearchParameters)' has a cyclomatic complexity of 22. Warning
| @@ -263,98 +273,98 @@ | |||
| * @param types | |||
| * @return | |||
| */ | |||
| /*package*/ String buildQueryString(String queryTerm, RecordsManagementSearchParameters searchParameters) | |||
| /* package */ String buildQueryString(String queryTerm, RecordsManagementSearchParameters searchParameters) | |||
Check warning
Code scanning / PMD
The method 'buildQueryString(String, RecordsManagementSearchParameters)' has an NPath complexity of 48640, current threshold is 200 Warning
| appendType(typeQuery, "rma:recordFolder"); | ||
| } | ||
| List<QName> includedContainerTypes = searchParameters.getIncludedContainerTypes(); | ||
| if (includedContainerTypes != null && includedContainerTypes.size() != 0) |
Check warning
Code scanning / PMD
Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() Warning
| } | ||
| else | ||
| { | ||
| query.append("keywords:\"" + queryTerm + "\""); |
Check warning
Code scanning / PMD
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). Warning
| ParameterCheck.mandatory("query", query); | ||
| ParameterCheck.mandatory("searchParameters", searchParameters); | ||
| @Override | ||
| public SavedSearchDetails saveSearch(String siteId, String name, String description, String query, RecordsManagementSearchParameters searchParameters, boolean isPublic) |
Check warning
Code scanning / PMD
Rather than using a lot of String arguments, consider using a container object for those values. Warning
| if (container == null) | ||
| { | ||
| container = AuthenticationUtil.runAs(new RunAsWork<NodeRef>() | ||
| { | ||
| container = AuthenticationUtil.runAs(new RunAsWork<NodeRef>() { |
Check warning
Code scanning / PMD
Explicit type arguments can be replaced by a diamond: `new RunAsWork<>()` Warning
| @@ -530,8 +542,7 @@ | |||
| if (userContainer == null) | |||
| { | |||
| final NodeRef parentContainer = container; | |||
| userContainer = AuthenticationUtil.runAs(new RunAsWork<NodeRef>() | |||
| { | |||
| userContainer = AuthenticationUtil.runAs(new RunAsWork<NodeRef>() { | |||
Check warning
Code scanning / PMD
Explicit type arguments can be replaced by a diamond: `new RunAsWork<>()` Warning
| @@ -547,8 +558,7 @@ | |||
| if (searchNode == null) | |||
| { | |||
| final NodeRef searchContainer = container; | |||
| searchNode = AuthenticationUtil.runAs(new RunAsWork<NodeRef>() | |||
| { | |||
| searchNode = AuthenticationUtil.runAs(new RunAsWork<NodeRef>() { | |||
Check warning
Code scanning / PMD
Explicit type arguments can be replaced by a diamond: `new RunAsWork<>()` Warning
...va/org/alfresco/module/org_alfresco_module_rm/search/RecordsManagementSearchServiceImpl.java
Show resolved
Hide resolved
https://hyland.atlassian.net/browse/MNT-23559
[Concern] When performing a records search on the RM site, the number of results returned is limited to a maximum of 500 items.
[Solution] As per the implementation, it retrieves a static value from the property file, which is why it is restricted to 500 items. However, upon reviewing the code, I noticed that the same method is being called from RMSearchGet, where we have the privilege to set a custom maximum number of items. Therefore, instead of using the default value from the property file, we are now setting the value from the caller method's arguments.