Ability to create configurable param from a given external struct #13733
+278
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
jackal1-66
previously approved these changes
Nov 25, 2024
sawenzel
force-pushed
the
swenzel/configParamTemplates
branch
from
fc26161
to
be69c17
Compare
This commit provides the new feature of being able to create
configurable param instances from a given external C++ struct.
For example, a C++ struct `struct A { double x; }` can be used to define
a correspondig configurable parameter via
```
class MyConfigParamA : o2::conf::ConfigurableParamPromoter<MyConfigParamA, A> {}
```
This allows to:
- have "template" structs to create multiple params of the same structure
- separate data from configkey functionality
- extract data copies from underlying configurable parameters
The application thereof is demonstrated for GeneratorPythia8Param.
A unit test is added to check the new functionality.
sawenzel
force-pushed
the
swenzel/configParamTemplates
branch
from
be69c17
to
0620fcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit provides the new feature of being able to create configurable param instances from a given external C++ struct.
For example, a C++ struct
struct A { double x; }can be used to define a correspondig configurable parameter viaThis allows to:
The application thereof is demonstrated for GeneratorPythia8Param.
A unit test is added to check the new functionality.