Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements on the MID reject list #13740

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Improvements on the MID reject list #13740

merged 1 commit into from
Nov 26, 2024
+96 −66

Conversation

dstocco
Copy link
Contributor

@dstocco dstocco commented Nov 26, 2024

  • Correctly build the reject list even for runs where the issue happens at the very last sampled QC object, just before EOR
  • Search for switched off boards at the end of the period with bad quality instead of the beginning. This should make sure that we do not miss additional boards that stops sending data
  • Remove additional time margin at the beginning and end of the run
  • Get run number from QC metadata

@dstocco
Improvements on the MID reject list
e29d2de 
- Correctly build the reject list even for runs where the issue happens at the very last sampled QC object, just before EOR
- Search for switched off boards at the end of the period with bad quality instead of the beginning. This should make sure that we do not miss additional boards that stops sending data
- Remove additional time margin at the beginning and end of the run
- Get run number from QC metadata
@dstocco dstocco requested review from shahor02 and a team as code owners November 26, 2024 15:53
@github-actions GitHub Actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@dstocco
Copy link
Contributor Author

dstocco commented Nov 26, 2024

@ariffero : for information

@shahor02 shahor02 merged commit 3d3ee4d into AliceO2Group:dev Nov 26, 2024
11 of 15 checks passed
@dstocco dstocco deleted the rejectlist branch November 27, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmassacr lmassacr lmassacr approved these changes

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dstocco @lmassacr @shahor02