GPU TPC: Fix TPC clusterizer qMax cut #13743
Merged
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking stored CTFs, I saw that we have clusters with qMax = 3, while we process with
cfQMaxCutoff = 3
, which should cut awayqMax <= 3
. I ran some local tests processing raw data, and I see that indeed the clusterizer produces clusters withqMax = 3
, while the cut seems to be correct:AliceO2/GPU/GPUTracking/TPCClusterFinder/GPUTPCCFPeakFinder.cxx
Line 45 in f76f1a7
Perhaps this is related to charge splitting between clusters? In any case, this PR fixes it by having a posterior cut on the qMax when the cluster is stored.
@fweig : Could you have a look and comment what happens in the clusterizer?