Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU TPC: Fix TPC clusterizer qMax cut #13743

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

davidrohr
Copy link
Collaborator

Checking stored CTFs, I saw that we have clusters with qMax = 3, while we process with cfQMaxCutoff = 3, which should cut away qMax <= 3. I ran some local tests processing raw data, and I see that indeed the clusterizer produces clusters with qMax = 3, while the cut seems to be correct:

bool belowThreshold = (q <= calib.tpc.cfQMaxCutoff);

Perhaps this is related to charge splitting between clusters? In any case, this PR fixes it by having a posterior cut on the qMax when the cluster is stored.

@fweig : Could you have a look and comment what happens in the clusterizer?

Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@davidrohr davidrohr merged commit 96e4188 into AliceO2Group:dev Nov 27, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant