-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating hypernuclei implementation in O2 #13746
Conversation
Adding correct implementations of hypernuclei
Inserting the correct implementation for hypernuclei, their masses, lifetimes and decay channels
Update Intendations
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Please consider the following formatting changes to AliceO2Group#13746
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this PR seems to contains significant formatting changes or removal of comments. I have difficulties seeing the actual changes in physics parameters that this PR provides, which makes the review process harder. Could you please provide a single commit with the least amount of changes possible?
Dear Sascha, Thanks for your comment. Unfortunately, I cannot do a commit containing only the changes due to format issues. The lines that were changed are 285-346 (fixing masses and lifetimes for hypernuclei and inserting Xi-bound states) and 724-1035 (adding the decay channels and Xi-bound states decay channels) in O2MCApplication.cxx, as well as 237-289 (fixing hypernuclei masses) in O2DatabasePDG.h. We also removed the excited states of the A=4 hypernuclei, since these excited states decay electromagnetically to the ground state which will be reconstructed. So only the ground state is needed (see also latest AliRoot implementation in AliMC.cxx). We updated the O2DatabasePDG.h again, since there were two hypernuclei named twice. |
Please consider the following formatting changes to AliceO2Group#13746
I am afraid this PR can not be merged in this form. The PR removes or restructures comments, changes include files or their order and applies other change that have nothing to do with your intented changes. Please open a fresh PR with just the relevant changes of updating physics constants. If there are formatting-issues I can try to fix them separately. A single well-contained commit would be appreciated. |
The O2 databases for MC were taken from an older AliRoot version and are not up-to-date. This commit updates the masses, lifetimes and decay channels for the hypernuclei.