Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options for collision context creation in (old) embedding path #1587

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

sawenzel
Copy link
Contributor

@sawenzel sawenzel commented Apr 9, 2024

did not take into account first-orbit, which is used in anchoring MC.

did not take into account first-orbit, which is used in anchoring MC.
Copy link

github-actions bot commented Apr 9, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6-2023-PbPb-apass2

@sawenzel
Copy link
Contributor Author

sawenzel commented Apr 9, 2024

+async-label async-2022-pp-apass4, async-2023-pbpb-apass, async-2023-pp-apass1, async-data async-mc, async-2022-pp-apass6-2023-PbPb-apass2

@github-actions github-actions bot added async-2022-pp-apass4 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 labels Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Hi @sawenzel, the following label names could not be recognised: async-data async-mc

@chiarazampolli
Copy link
Collaborator

Hello @sawenzel , @benedikt-voelkel ,

This is still open, but it was requested for new tags. Can it be merged?

Chiara

@benedikt-voelkel
Copy link
Contributor

benedikt-voelkel commented Apr 12, 2024

This was also tested by @fgrosa and also from the changes, it looks all fine.
And CIs went through, so:
Merging.

@benedikt-voelkel benedikt-voelkel merged commit 5e94376 into master Apr 12, 2024
11 checks passed
@benedikt-voelkel benedikt-voelkel deleted the swenzel/patch-digicontext-embedding branch April 12, 2024 08:37
noferini pushed a commit that referenced this pull request Apr 12, 2024
…1587)

did not take into account first-orbit, which is used in anchoring MC.
@noferini noferini removed the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Apr 18, 2024
noferini pushed a commit that referenced this pull request Apr 18, 2024
…1587)

did not take into account first-orbit, which is used in anchoring MC.
noferini pushed a commit that referenced this pull request Apr 19, 2024
…1587)

did not take into account first-orbit, which is used in anchoring MC.
benedikt-voelkel pushed a commit that referenced this pull request May 16, 2024
…1587)

did not take into account first-orbit, which is used in anchoring MC.

(cherry picked from commit 5e94376)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants