Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamically manipulating always the local json file in GLO QC, for K0s #1850

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

ehellbar
Copy link
Collaborator

and minor formatting changes (spaces instead of tabs)

this is required to make #1834 work also in online

  • downloading the json from apricot to local and adding it to the JSON_FILES
    • when using local jsons to begin with, they are also added to JSON_FILES in the add_QC_JSON function
  • manipulating the local json taken from JSON_FILES and store it in a temporary file
  • replace the initial local json with the manipulated temporary file in JSON_FILES

please do not merge yet, should be tested in online first

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@chiarazampolli
Copy link
Collaborator

Hi @ehellbar ,

I assume the changes are needed since something in online did not work. I tested both FST and async reco, and there all was fine.

Chiara

@shahor02
Copy link
Collaborator

In the online topology creation, the consul path was treated as a local file.

@shahor02 shahor02 merged commit 738007c into AliceO2Group:master Dec 13, 2024
8 checks passed
@chiarazampolli
Copy link
Collaborator

Ok, thanks!

@ehellbar
Copy link
Collaborator Author

tested in online on STG, works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants