-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to treat holes in run + Smaller fixes #1854
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Hi, Thanks! Do I understand that only exclusion is foreseen (no white list)? Cheers, Chiara |
return False | ||
|
||
# read txt file into a pandas dataframe ---> if this fails catch exception and return | ||
df = pd.read_csv(filename, header=None, names=["Run", "From", "To", "Message"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the CTFReader accepts delimiters like ,
, ;
, space and tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this based on the example file that was given to me. Wouldn't it be easier to have a simple rule for this file?
And I am not sure that space as a delimiter is useful because the example file contained words like FC unstable
which would probably be split incorrectly.
Will make the code more generic tomorrow. For now it works and I need to have it in the nightly tag for testing tomorrow/
Don't know. So far, we only talked about exclusion. Can add the other thing later. |
https://its.cern.ch/jira/browse/O2-5626