Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to treat holes in run + Smaller fixes #1854

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

sawenzel
Copy link
Contributor

@sawenzel sawenzel commented Dec 17, 2024

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@sawenzel
Copy link
Contributor Author

@chiarazampolli
Copy link
Collaborator

Hi,

Thanks! Do I understand that only exclusion is foreseen (no white list)?

Cheers,

Chiara

return False

# read txt file into a pandas dataframe ---> if this fails catch exception and return
df = pd.read_csv(filename, header=None, names=["Run", "From", "To", "Message"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the CTFReader accepts delimiters like ,, ;, space and tab.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this based on the example file that was given to me. Wouldn't it be easier to have a simple rule for this file?
And I am not sure that space as a delimiter is useful because the example file contained words like FC unstable which would probably be split incorrectly.

Will make the code more generic tomorrow. For now it works and I need to have it in the nightly tag for testing tomorrow/

@sawenzel
Copy link
Contributor Author

Hi,

Thanks! Do I understand that only exclusion is foreseen (no white list)?

Cheers,

Chiara

Don't know. So far, we only talked about exclusion. Can add the other thing later.

@sawenzel sawenzel merged commit 7b88f33 into AliceO2Group:master Dec 17, 2024
6 checks passed
@sawenzel sawenzel deleted the swenzel/holes branch December 17, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants