Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to set EMC busy time to 0 #1861

Closed
wants to merge 1 commit into from

Conversation

jaimenorman
Copy link
Contributor

this option is useful for simulation setups where we want the EMCal to be read out for every event, in order to increase the number of events that the EMCal is available, for statistics reasons

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@alcaliva alcaliva enabled auto-merge (squash) January 9, 2025 11:38
@sawenzel
Copy link
Contributor

sawenzel commented Jan 9, 2025

@jaimenorman : Thanks for your PR. Could you check if the alternative proposal #1869 would work for you as well. This solution is slightly more generic and would work for other users as well (without the need to add detector specific command line options such as --emc-remove-busy).

@sawenzel
Copy link
Contributor

sawenzel commented Jan 9, 2025

Closing this (in favour of #1869). Discussed with @jaimenorman in private.

@sawenzel sawenzel closed this Jan 9, 2025
auto-merge was automatically disabled January 9, 2025 13:14

Pull request was closed

@jaimenorman
Copy link
Contributor Author

Thanks @sawenzel, I tested that your PR #1869 works well for this goal, and can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants