bugfix: failed to validate namespace value #2393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2393 +/- ##
=========================================
- Coverage 68.45% 68.4% -0.06%
=========================================
Files 275 276 +1
Lines 18291 18283 -8
=========================================
- Hits 12522 12507 -15
- Misses 4340 4346 +6
- Partials 1429 1430 +1
|
starnop
reviewed
Oct 31, 2018
daemon/mgr/container_validation.go
Outdated
| return fmt.Errorf("invalid uts namespace mode %s", hostConfig.UTSMode) | ||
| } | ||
|
|
||
| if !ns.Valid(specs.PIDNamespace, hostConfig.IpcMode) { |
There was a problem hiding this comment.
PIDNamespace or IPCNamespace ? So do that with UTS.
|
related to issue #2378 |
|
@rudyfly ， could you take a look at network part ? |
namespace related parameters not get validated, user should know the valid value and invalid value when they specify the related parameters. remove repeated code in network namespace Signed-off-by: Ace-Tang <[email protected]>
Signed-off-by: Ace-Tang <[email protected]>
|
ping @Ace-Tang |
|
please reopen it if you need |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
namespace related parameters not get validated, user should know
the valid value and invalid value when they specify the related
parameters.
remove repeated code in network namespace
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
add namespace related tests for run command
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews