Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/czireader float32 dtype #423

Merged
merged 6 commits into from
Jul 28, 2022
Merged

Fix/czireader float32 dtype #423

merged 6 commits into from
Jul 28, 2022

Conversation

toloudis
Copy link
Collaborator

Description

Fixes #421
in which a czi with float32 pixels was crashing. aicspylibczi seems to already support that dtype.

@toloudis toloudis changed the base branch from main to fix/czireader-channel-name-key-error July 28, 2022 21:43
Copy link
Collaborator

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests going to fail until new version of fsspec is released but looks good to me!

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #423 (7b7f687) into fix/czireader-channel-name-key-error (3c8c3d0) will not change coverage.
The diff coverage is n/a.

@@                          Coverage Diff                          @@
##           fix/czireader-channel-name-key-error     #423   +/-   ##
=====================================================================
  Coverage                                 57.45%   57.45%           
=====================================================================
  Files                                        46       46           
  Lines                                      3972     3972           
=====================================================================
  Hits                                       2282     2282           
  Misses                                     1690     1690           
Impacted Files Coverage Δ
aicsimageio/readers/czi_reader.py 6.68% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c8c3d0...7b7f687. Read the comment docs.

Base automatically changed from fix/czireader-channel-name-key-error to main July 28, 2022 23:33
@toloudis toloudis merged commit b42b747 into main Jul 28, 2022
@toloudis toloudis deleted the fix/czireader-float32-dtype branch July 28, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error when reading 32 bit czi file
3 participants