-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix single dimension index when requested as a returned dim #438
Conversation
… exists in requested dims
Codecov ReportBase: 86.95% // Head: 86.95% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
=======================================
Coverage 86.95% 86.95%
=======================================
Files 46 46
Lines 4001 4001
=======================================
Hits 3479 3479
Misses 522 522
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
oops I didn't run all tests locally.. I'll fix them in next commit. |
tests should be ok now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Thanks a lot for fixing this! |
Unfortunately it won't be released for a bit. There are a few other PRs in progress to get shipped too. |
Fixes #435
Now you can do both of:
and
Both will now return a 3d array (assuming the data validly has at least CYX dims, of course)
Where before, passing a single C selection and at the same time requesting C in the returned dims was an error.