Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix single dimension index when requested as a returned dim #438

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

toloudis
Copy link
Collaborator

Fixes #435

Now you can do both of:

im_read.get_image_data("CYX", C=[0], T=0, Z=0)

and

im_read.get_image_data("CYX", C=0, T=0, Z=0)

Both will now return a 3d array (assuming the data validly has at least CYX dims, of course)
Where before, passing a single C selection and at the same time requesting C in the returned dims was an error.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Base: 86.95% // Head: 86.95% // No change to project coverage 👍

Coverage data is based on head (f40c161) compared to base (0d46966).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          46       46           
  Lines        4001     4001           
=======================================
  Hits         3479     3479           
  Misses        522      522           
Impacted Files Coverage Δ
aicsimageio/tests/test_transforms.py 99.00% <ø> (ø)
aicsimageio/transforms.py 99.01% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@toloudis
Copy link
Collaborator Author

oops I didn't run all tests locally.. I'll fix them in next commit.

@toloudis
Copy link
Collaborator Author

tests should be ok now

Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@evamaxfield evamaxfield merged commit 405ab6e into main Sep 22, 2022
@evamaxfield evamaxfield deleted the fix/435-dims-requested-as-list branch September 22, 2022 17:14
@guiwitz
Copy link

guiwitz commented Sep 22, 2022

Thanks a lot for fixing this!

@evamaxfield
Copy link
Collaborator

Unfortunately it won't be released for a bit. There are a few other PRs in progress to get shipped too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to import dimension with multiple indices
5 participants