Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/citation-update #440

Merged
merged 1 commit into from
Oct 11, 2022
Merged

admin/citation-update #440

merged 1 commit into from
Oct 11, 2022

Conversation

evamaxfield
Copy link
Collaborator

Update citation to include specific names and add bibtex example

@evamaxfield evamaxfield added documentation Improvements or additions to documentation admin Various administrative tasks for the package labels Oct 6, 2022
@evamaxfield evamaxfield self-assigned this Oct 6, 2022
Copy link
Collaborator

@tlambert03 tlambert03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honored 😊

@evamaxfield
Copy link
Collaborator Author

Proud of myself for having written correct bibtex on the first try:
image

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 86.95% // Head: 86.95% // No change to project coverage 👍

Coverage data is based on head (d37913b) compared to base (405ab6e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #440   +/-   ##
=======================================
  Coverage   86.95%   86.95%           
=======================================
  Files          46       46           
  Lines        4001     4001           
=======================================
  Hits         3479     3479           
  Misses        522      522           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and very cool! One question though, should this use the current year? Or does it not matter?

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@evamaxfield
Copy link
Collaborator Author

Going ahead with merge without @heeler's sign off.

@evamaxfield evamaxfield merged commit 8099b70 into main Oct 11, 2022
@evamaxfield evamaxfield deleted the admin/citation-update branch October 11, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Various administrative tasks for the package documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants