-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/fix_future_warnings #453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me! Thanks for contributing!
Assuming all tests pass, will merge.
Codecov ReportBase: 94.00% // Head: 94.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
=======================================
Coverage 94.00% 94.00%
=======================================
Files 46 46
Lines 4021 4021
=======================================
Hits 3780 3780
Misses 241 241
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Test failures thus far are seemingly unrelated:
|
they are indeed unrelated but I am wondering why they are getting picked up by the test suite at all. Need to investigate before merge now. Sorry. |
I think its the new Can you try pinning |
@JasonYu1 you pinned |
Thanks! Looks like that was the issue. Will wait for second approval but good from me! |
Description
I encountered the following future warnings
I applied the suggested fix which is to use
.items
Pull request recommendations:
Thanks for contributing!