Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/fix_future_warnings #453

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Conversation

JasonYu1
Copy link
Contributor

@JasonYu1 JasonYu1 commented Dec 9, 2022

Description

I encountered the following future warnings

FutureWarning: iteritems is deprecated and will be removed in a future version. Use .items instead.
  for i, x in scene_files_nunique.iteritems():

I applied the suggested fix which is to use .items

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • [?] Provide relevant tests for your feature or bug fix.

Thanks for contributing!

@evamaxfield evamaxfield added the enhancement New feature or request label Dec 9, 2022
Copy link
Collaborator

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me! Thanks for contributing!

Assuming all tests pass, will merge.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Base: 94.00% // Head: 94.00% // No change to project coverage 👍

Coverage data is based on head (2b1129b) compared to base (25d561e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #453   +/-   ##
=======================================
  Coverage   94.00%   94.00%           
=======================================
  Files          46       46           
  Lines        4021     4021           
=======================================
  Hits         3780     3780           
  Misses        241      241           
Impacted Files Coverage Δ
aicsimageio/readers/tiff_glob_reader.py 86.77% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ianhi
Copy link
Contributor

ianhi commented Dec 9, 2022

Test failures thus far are seemingly unrelated:


=================================== ERRORS ====================================
_ ERROR collecting aicsimageio/tests/readers/extra_readers/test_bioformats_reader.py _
ImportError while importing test module 'D:\a\aicsimageio\aicsimageio\aicsimageio\tests\readers\extra_readers\test_bioformats_reader.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
aicsimageio\readers\bioformats_reader.py:34: in <module>
    import jpype
E   ModuleNotFoundError: No module named 'jpype'

@evamaxfield
Copy link
Collaborator

Test failures thus far are seemingly unrelated

they are indeed unrelated but I am wondering why they are getting picked up by the test suite at all. Need to investigate before merge now. Sorry.

@evamaxfield
Copy link
Collaborator

I think its the new tox major version release. https://pypi.org/project/tox/

Can you try pinning tox==3.27.1 in setup.py and pushing

@evamaxfield
Copy link
Collaborator

@JasonYu1 you pinned tox>=, can you pin tox==

@evamaxfield
Copy link
Collaborator

Thanks! Looks like that was the issue. Will wait for second approval but good from me!

@evamaxfield evamaxfield merged commit b9925b3 into AllenCellModeling:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants