-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to use optimized codepath through ome-types #478
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
=======================================
Coverage 94.16% 94.16%
=======================================
Files 48 48
Lines 4197 4197
=======================================
Hits 3952 3952
Misses 245 245
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay. Less warnings!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Description
Using OmeTiffReader often shows this warning
Passing "lxml" explicitly will not only remove the warning but actually causes a very noticeable speedup in initial parsing of ome-tiff metadata.
Addresses #479 (coincidentally reported after this PR) and a report from an internal user.
There is also a "bonus" test fix due to calling a deprecated
iteritems
in a pandas Series object.