Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pyproject.toml ... modernize build #51

Merged
merged 8 commits into from
Jul 24, 2022

Conversation

tlambert03
Copy link
Contributor

Pull request recommendations:
Here's the obnoxious repo update i was referring to :) while it was easier to do this all in one, I can break it up into smaller ones if you want. (and I will comment inline on things that might not be obvious)

or... if you're happy with things as they are, that's fine too :)

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #51 (8c31339) into main (efee3a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files           3        3           
  Lines         189      189           
=======================================
  Hits          168      168           
  Misses         21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efee3a9...8c31339. Read the comment docs.

.bumpversion.cfg Show resolved Hide resolved
.github/dependabot.yml Show resolved Hide resolved
.github/workflows/build-main.yml Show resolved Hide resolved
.github/workflows/build-main.yml Show resolved Hide resolved
.github/workflows/build-main.yml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
setup.py Show resolved Hide resolved
@evamaxfield
Copy link
Collaborator

omg. I will look at this over the weekend but i truly can't thank you enough. actively learning all the new things.

Copy link
Collaborator

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

90% of this makes sense to me! A few questions and comments. I really appreciate you doing this ❤️

.github/dependabot.yml Show resolved Hide resolved
.github/workflows/build-main.yml Show resolved Hide resolved
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@evamaxfield evamaxfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming lint passes. Looks good to me! Thanks again!

@evamaxfield evamaxfield merged commit cba1f91 into AllenCellModeling:main Jul 24, 2022
@tlambert03 tlambert03 deleted the pyproject branch July 24, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants