-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use pyproject.toml ... modernize build #51
Conversation
Codecov Report
@@ Coverage Diff @@
## main #51 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 3 3
Lines 189 189
=======================================
Hits 168 168
Misses 21 21 Continue to review full report at Codecov.
|
omg. I will look at this over the weekend but i truly can't thank you enough. actively learning all the new things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
90% of this makes sense to me! A few questions and comments. I really appreciate you doing this ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming lint passes. Looks good to me! Thanks again!
Pull request recommendations:
Here's the obnoxious repo update i was referring to :) while it was easier to do this all in one, I can break it up into smaller ones if you want. (and I will comment inline on things that might not be obvious)
or... if you're happy with things as they are, that's fine too :)